Skip to content

Revert jenkins removal#3828

Merged
jlind23 merged 2 commits intoelastic:mainfrom
fearful-symmetry:revert-jenkins-removal
Nov 28, 2023
Merged

Revert jenkins removal#3828
jlind23 merged 2 commits intoelastic:mainfrom
fearful-symmetry:revert-jenkins-removal

Conversation

@fearful-symmetry
Copy link
Contributor

@fearful-symmetry fearful-symmetry commented Nov 28, 2023

What does this PR do?

Partly reverts #3771

Turns out that some scripts in dev-tools still depends on scrips in .ci/, so we're breaking the unified release process.

This PR should be reverted once the dangling references to the files in .ci/ are dealt with:

➜  elastic-agent git:(revert-jenkins-removal) ✗ grep -rn "\.ci/" .
./.pre-commit-config.yaml:11:        files: ^(.ci/(.*\.groovy|Jenkinsfile)|Jenkinsfile)$
./magefile.go:452:// this follows the same logic as https://github.com/elastic/beats/blob/2fdefcfbc783eb4710acef07d0ff63863fa00974/.ci/scripts/prepare-release-manager.sh
./.github/workflows/bump-golang.yml:24:          pipeline: ./.ci/bump-golang.yml
./dev-tools/common.bash:48:  GO_VERSION="${version}" "${BASEDIR}"/.ci/scripts/install-go.sh

@mergify
Copy link
Contributor

mergify bot commented Nov 28, 2023

This pull request does not have a backport label. Could you fix it @fearful-symmetry? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 8./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

Copy link
Contributor

@jlind23 jlind23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jlind23
Copy link
Contributor

jlind23 commented Nov 28, 2023

Force merging this to unblock the unified release process.

@jlind23 jlind23 merged commit 85325ad into elastic:main Nov 28, 2023
@elastic-sonarqube
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@pierrehilbert pierrehilbert added the backport-v8.11.0 Automated backport with mergify label Dec 12, 2023
mergify bot pushed a commit that referenced this pull request Dec 12, 2023
* partly revert removal of jenkins-related scripts

(cherry picked from commit 85325ad)
pierrehilbert pushed a commit that referenced this pull request Dec 12, 2023
* partly revert removal of jenkins-related scripts

(cherry picked from commit 85325ad)

Co-authored-by: Alex K <8418476+fearful-symmetry@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants