Skip to content

ironbank: use ubi:9.3#3787

Merged
v1v merged 2 commits intoelastic:mainfrom
v1v:feature/use-ubi-9.3
Nov 23, 2023
Merged

ironbank: use ubi:9.3#3787
v1v merged 2 commits intoelastic:mainfrom
v1v:feature/use-ubi-9.3

Conversation

@v1v
Copy link
Member

@v1v v1v commented Nov 20, 2023

What does this PR do?

Bump the ubi:9 version to 9.3 as requested

Why is it important?

Ironbank to use the latest secured version

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

Questions to ask yourself

  • How are we going to support this in production?
  • How are we going to measure its adoption?
  • How are we going to debug this?
  • What are the metrics I should take care of?
  • ...

@v1v v1v added automation backport-v8.11.0 Automated backport with mergify labels Nov 20, 2023
@v1v v1v requested review from a team and cmacknz November 20, 2023 14:20
@v1v v1v self-assigned this Nov 20, 2023
@v1v v1v requested a review from a team as a code owner November 20, 2023 14:20
@v1v v1v requested a review from blakerouse November 20, 2023 14:20
@pierrehilbert pierrehilbert added the Team:Elastic-Agent Label for the Agent team label Nov 20, 2023
@elasticmachine
Copy link
Contributor

elasticmachine commented Nov 20, 2023

Pinging @elastic/elastic-agent (Team:Elastic-Agent)

@v1v
Copy link
Member Author

v1v commented Nov 20, 2023

I don't know whether there is a need for a changelog entry, @pierrehilbert , do I need one? Or the skipped is good enough?

@pierrehilbert
Copy link
Contributor

pierrehilbert commented Nov 20, 2023

I don't think this is necessary and I would skip it instead.

@elasticmachine
Copy link
Contributor

elasticmachine commented Nov 20, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-11-20T14:21:12.339+0000

  • Duration: 54 min 45 sec

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages.

  • run integration tests : Run the Elastic Agent Integration tests.

  • run end-to-end tests : Generate the packages and run the E2E Tests.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@v1v v1v requested a review from a team November 20, 2023 15:43
@v1v v1v enabled auto-merge (squash) November 21, 2023 08:22
@v1v
Copy link
Member Author

v1v commented Nov 21, 2023

@elastic/elastic-agent-control-plane , I need your 👀 for this PR

@v1v v1v requested review from a team and removed request for a team November 21, 2023 08:25
@pierrehilbert
Copy link
Contributor

pierrehilbert commented Nov 21, 2023

We have an opened PR related to this error: #3792
Would it be okay for you to wait a bit for this to be merged?

@v1v v1v mentioned this pull request Nov 21, 2023
Merged
7 tasks
blakerouse
blakerouse approved these changes Nov 21, 2023
View reviewed changes
Copy link
Contributor

@blakerouse blakerouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Sadly non of these changes are really being tested by the integration testing framework. I don't see the need to wait for those fixes for this to be merged.

@v1v
Copy link
Member Author

v1v commented Nov 23, 2023

@Mergifyio rebase

@mergify
Copy link
Contributor

mergify bot commented Nov 23, 2023

rebase

✅ Branch has been successfully rebased

@v1v v1v force-pushed the feature/use-ubi-9.3 branch from f36ca88 to de8cf8a Compare November 23, 2023 08:17
@elastic-sonarqube
Copy link

elastic-sonarqube bot commented Nov 23, 2023

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@v1v
Copy link
Member Author

v1v commented Nov 23, 2023

post-build step to process the test results failed:

image

This is now ready to be merged

@v1v v1v merged commit a6e0c1a into elastic:main Nov 23, 2023
mergify bot pushed a commit that referenced this pull request Nov 23, 2023
@v1v @mergify
ironbank: use ubi:9.3 (#3787)
ab03ca7 
(cherry picked from commit a6e0c1a)
@mergify mergify bot mentioned this pull request Nov 23, 2023
Merged
belimawr pushed a commit to belimawr/elastic-agent that referenced this pull request Nov 28, 2023
@mergify @v1v
ironbank: use ubi:9.3 (elastic#3787) (elastic#3807)
eaaf07a 
(cherry picked from commit a6e0c1a)

Co-authored-by: Victor Martinez <[email protected]>
This was referenced Aug 27, 2024
Merged
Merged
@mergify mergify bot mentioned this pull request Sep 4, 2024
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pierrehilbert pierrehilbert pierrehilbert approved these changes

@blakerouse blakerouse blakerouse approved these changes

@kuisathaverat kuisathaverat kuisathaverat approved these changes

@amannocci amannocci amannocci approved these changes

@cmacknz cmacknz Awaiting requested review from cmacknz

Assignees

@v1v v1v

Labels

automation backport-v8.11.0 Automated backport with mergify skip-changelog Team:Elastic-Agent Label for the Agent team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@v1v @elasticmachine @pierrehilbert @blakerouse @kuisathaverat @amannocci