Skip to content

Migrate check-ci step to buildkite#3759

Merged
pazone merged 7 commits intomainfrom
buildkite_checkci_migration
Nov 20, 2023
Merged

Migrate check-ci step to buildkite#3759
pazone merged 7 commits intomainfrom
buildkite_checkci_migration

Conversation

@pazone
Copy link
Contributor

@pazone pazone commented Nov 13, 2023

What does this PR do?

Migrates check ci step to buildkite

@pazone pazone added enhancement New feature or request skip-changelog backport-v8.10.0 Automated backport with mergify backport-v8.11.0 Automated backport with mergify labels Nov 13, 2023
@pazone pazone requested a review from a team as a code owner November 13, 2023 12:02
@pazone pazone requested review from pchila and ycombinator November 13, 2023 12:02
@mergify mergify bot assigned pazone Nov 13, 2023
@pierrehilbert pierrehilbert added Team:Elastic-Agent Label for the Agent team and removed backport-v8.10.0 Automated backport with mergify labels Nov 13, 2023
@elasticmachine
Copy link
Contributor

elasticmachine commented Nov 13, 2023

Pinging @elastic/elastic-agent (Team:Elastic-Agent)

@elasticmachine
Copy link
Contributor

elasticmachine commented Nov 13, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-11-14T16:32:20.074+0000

  • Duration: 5 min 10 sec

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages.

  • run integration tests : Run the Elastic Agent Integration tests.

  • run end-to-end tests : Generate the packages and run the E2E Tests.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

pchila
pchila reviewed Nov 14, 2023
View reviewed changes
Copy link
Member

@pchila pchila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Migration of the step looks ok, however jenkins pipeline is now broken
https://fleet-ci.elastic.co/blue/organizations/jenkins/elastic-agent%2Felastic-agent-mbp/detail/PR-3759/2/pipeline/157/

I suspect that removing

setEnvVar('BEAT_VERSION', sh(label: 'Get beat version', script: 'make get-version', returnStdout: true)?.trim())

had some unforeseen side effects (or maybe there some other side effect of make check-ci that is now missing 🤔

@pazone
Copy link
Contributor Author

pazone commented Nov 14, 2023

@pchila We concluded that the package step is used by e2e tests that are deprecated. So we can remove it.

@cmacknz cmacknz requested a review from a team November 14, 2023 22:25
alexsapran
alexsapran reviewed Nov 15, 2023
View reviewed changes
@pazone
Copy link
Contributor Author

pazone commented Nov 16, 2023

@pchila @ycombinator Could you please revisit this PR?

@pazone pazone mentioned this pull request Nov 16, 2023
Merged
@pazone pazone merged commit 08c5150 into main Nov 20, 2023
@pazone pazone deleted the buildkite_checkci_migration branch November 20, 2023 14:25
mergify bot pushed a commit that referenced this pull request Nov 20, 2023
@pazone @mergify
Migrate check-ci step to buildkite (#3759)
6b4d5a9 
* Migrate check-ci step to buildkite

* Remove check-ci stage form jenkinsfile

* Migrate check-ci step to buildkite

* Migrate check-ci step to buildkite

* chmod check-ci.sh

* Removed package step

(cherry picked from commit 08c5150)

# Conflicts:
#	.buildkite/pipeline.yml
@mergify mergify bot mentioned this pull request Nov 20, 2023
Merged
@elastic-sonarqube
Copy link

elastic-sonarqube bot commented Nov 20, 2023

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

belimawr pushed a commit to belimawr/elastic-agent that referenced this pull request Nov 28, 2023
@mergify @pazone
[8.11](backport elastic#3759) Migrate check-ci step to buildkite (ela…
fe1d78b 
…stic#3791)

* Migrate check-ci step to buildkite (elastic#3759)

* Migrate check-ci step to buildkite

* Remove check-ci stage form jenkinsfile

* Migrate check-ci step to buildkite

* Migrate check-ci step to buildkite

* chmod check-ci.sh

* Removed package step

(cherry picked from commit 08c5150)

# Conflicts:
#	.buildkite/pipeline.yml

* Merged with 8.11

---------

Co-authored-by: Pavel Zorin <pavel.zorin@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexsapran alexsapran alexsapran left review comments

@pchila pchila pchila approved these changes

@ycombinator ycombinator Awaiting requested review from ycombinator ycombinator is a code owner automatically assigned from elastic/elastic-agent-control-plane

Assignees

@pazone pazone

Labels

backport-v8.11.0 Automated backport with mergify enhancement New feature or request skip-changelog Team:Elastic-Agent Label for the Agent team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@pazone @elasticmachine @alexsapran @pchila @pierrehilbert