-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[8.6] Use v1 data stream names for log shipping #1845
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blakerouse
added
the
Team:Elastic-Agent-Control-Plane
Label for the Agent Control Plane team
label
Nov 30, 2022
blakerouse
requested review from
aleksmaus and
michalpristas
and removed request for
a team
November 30, 2022 15:04
aleksmaus
approved these changes
Nov 30, 2022
Changes look good. Have you confirmed this works as expected with Fleet? |
🌐 Coverage report
|
Yes I have confirmed this works with Fleet. |
I am going to forward port this to main to avoid having to triage reports that this is broken there. The plan is still to follow up and adjust the data stream names in 8.7. |
mergify bot
pushed a commit
that referenced
this pull request
Dec 6, 2022
) (cherry picked from commit 6bf8465)
cmacknz
pushed a commit
that referenced
this pull request
Dec 6, 2022
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Changes the elastic-agent log monitoring to use the old names that match v1. This is for 8.6 only!
Why is it important?
So no fixes are required on Fleet side for new v2 architecture to work with 8.6.
Checklist
My code follows the style guidelines of this project
I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files[ ] I have added tests that prove my fix is effective or that my feature works[ ] I have added an entry inCHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Relates V2: Elastic agent monitoring data stream names should not be per process #1814
Closes (8.6) V2: Spawned process logs cannot be sent to fleet #1847