Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.6] Use v1 data stream names for log shipping #1845

Merged
merged 1 commit into from
Nov 30, 2022

Conversation

blakerouse
Copy link
Contributor

@blakerouse blakerouse commented Nov 30, 2022

What does this PR do?

Changes the elastic-agent log monitoring to use the old names that match v1. This is for 8.6 only!

Why is it important?

So no fixes are required on Fleet side for new v2 architecture to work with 8.6.

Checklist

@blakerouse blakerouse added the Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team label Nov 30, 2022
@blakerouse blakerouse requested a review from a team as a code owner November 30, 2022 15:04
@blakerouse blakerouse self-assigned this Nov 30, 2022
@blakerouse blakerouse requested review from aleksmaus and michalpristas and removed request for a team November 30, 2022 15:04
@cmacknz
Copy link
Member

cmacknz commented Nov 30, 2022

Changes look good. Have you confirmed this works as expected with Fleet?

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-11-30T15:04:54.383+0000

  • Duration: 18 min 35 sec

Test stats 🧪

Test Results
Failed 0
Passed 4613
Skipped 13
Total 4626

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages.

  • run integration tests : Run the Elastic Agent Integration tests.

  • run end-to-end tests : Generate the packages and run the E2E Tests.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@elasticmachine
Copy link
Contributor

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 98.333% (59/60) 👍
Files 69.082% (143/207) 👍
Classes 69.133% (271/392) 👍
Methods 53.8% (814/1513) 👍
Lines 38.967% (8789/22555) 👎 -0.035
Conditionals 100.0% (0/0) 💚

@blakerouse
Copy link
Contributor Author

Yes I have confirmed this works with Fleet.

@cmacknz
Copy link
Member

cmacknz commented Dec 6, 2022

I am going to forward port this to main to avoid having to triage reports that this is broken there. The plan is still to follow up and adjust the data stream names in 8.7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
forwardport-main Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants