Implement verifier receiver#13021
Conversation
|
This pull request does not have a backport label. Could you fix it @jeniawhite? 🙏
|
|
Let's move this to |
|
Also include a codeowners change marking your team as the owners of verifierreceiver |
|
This pull request is now in conflicts. Could you fix it? 🙏 |
e7bcc31 to
e1fb61e
Compare
|
This pull request is now in conflicts. Could you fix it? 🙏 |
1 similar comment
|
This pull request is now in conflicts. Could you fix it? 🙏 |
|
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
cmacknz
left a comment
There was a problem hiding this comment.
Only looked at the pieces outside of the verifier receiver itself, probably you want to assign an engineer from the cloud-services team to review that since they'll get all the following review requests for changes to it.
|
This pull request is now in conflicts. Could you fix it? 🙏 |
1 similar comment
|
This pull request is now in conflicts. Could you fix it? 🙏 |
dfadb16 to
ff7bab3
Compare
|
Structure looks good to me. I'll approve once you get approval from someone on your team that they want this to merge. Alternatively, for a bit more work, you can take the structural parts of this to main with a stub for the verifier receiver and I'll approve that. Then this PR will request codeowner approval from the right people and you won't need someone from agent control plane to approve everytime you push. |
|
Actually you'll probably need our approval because of go.mod changes, so don't bother with that. Just ping me/control plane once you have approval from your own team that this is good to merge and we'll approve. |
|
This pull request is now in conflicts. Could you fix it? 🙏 |
…t into evgb-ImpVerifier
|
This pull request is now in conflicts. Could you fix it? 🙏 |
The merge-base changed after approval.
The merge-base changed after approval.
💛 Build succeeded, but was flaky
Failed CI Steps
History
cc @jeniawhite |
Summary
elastic/opentelemetry-collector-componentsintoelastic-agent/internal/pkg/otel/receivers/verifierreceiver/.