Skip to content

Implement verifier receiver#13021

Merged
jeniawhite merged 79 commits into
elastic:mainfrom
jeniawhite:evgb-ImpVerifier
Apr 6, 2026
Merged

Implement verifier receiver#13021
jeniawhite merged 79 commits into
elastic:mainfrom
jeniawhite:evgb-ImpVerifier

Conversation

@jeniawhite
Copy link
Copy Markdown
Contributor

@jeniawhite jeniawhite commented Mar 3, 2026

Summary

  • Moves the verifier receiver from elastic/opentelemetry-collector-components into elastic-agent/internal/pkg/otel/receivers/verifierreceiver/.
  • Per review feedback from @axw and @cmacknz, this receiver is EDOT Collector-only and belongs in elastic-agent under ELv2 rather than the shared Apache-licensed OTel components repo.
  • Replaces Introduce verifier receiver to EDOT #12728 (which imported the receiver as an external dependency from opentelemetry-collector-components).

@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Mar 3, 2026

This pull request does not have a backport label. Could you fix it @jeniawhite? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-./d./d is the label that automatically backports to the 8./d branch. /d is the digit
  • backport-active-all is the label that automatically backports to all active branches.
  • backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
  • backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.

@jeniawhite jeniawhite changed the title Move verifier receiver from opentelemetry-collector-components to elastic-agent Implement verifier receiver Mar 3, 2026
@jeniawhite jeniawhite marked this pull request as draft March 3, 2026 23:03
@swiatekm
Copy link
Copy Markdown
Member

swiatekm commented Mar 4, 2026

Let's move this to internal/edot, there's no reason for it to live in the elastic-agent module.

@cmacknz
Copy link
Copy Markdown
Member

cmacknz commented Mar 4, 2026

Also include a codeowners change marking your team as the owners of verifierreceiver

@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Mar 4, 2026

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b evgb-ImpVerifier upstream/evgb-ImpVerifier
git merge upstream/main
git push upstream evgb-ImpVerifier

@jeniawhite jeniawhite force-pushed the evgb-ImpVerifier branch 3 times, most recently from e7bcc31 to e1fb61e Compare March 4, 2026 21:40
@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Mar 5, 2026

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b evgb-ImpVerifier upstream/evgb-ImpVerifier
git merge upstream/main
git push upstream evgb-ImpVerifier

1 similar comment
@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Mar 6, 2026

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b evgb-ImpVerifier upstream/evgb-ImpVerifier
git merge upstream/main
git push upstream evgb-ImpVerifier

@jeniawhite jeniawhite marked this pull request as ready for review March 6, 2026 19:08
@pierrehilbert pierrehilbert added the Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team label Mar 8, 2026
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

Copy link
Copy Markdown
Member

@cmacknz cmacknz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only looked at the pieces outside of the verifier receiver itself, probably you want to assign an engineer from the cloud-services team to review that since they'll get all the following review requests for changes to it.

Comment thread agents/elastic-agent-verifier/SKILL.md Outdated
Comment thread internal/pkg/otel/testdata/all-components-fips.yml
@jeniawhite jeniawhite marked this pull request as draft March 13, 2026 06:38
@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Mar 13, 2026

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b evgb-ImpVerifier upstream/evgb-ImpVerifier
git merge upstream/main
git push upstream evgb-ImpVerifier

1 similar comment
@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Mar 18, 2026

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b evgb-ImpVerifier upstream/evgb-ImpVerifier
git merge upstream/main
git push upstream evgb-ImpVerifier

@jeniawhite jeniawhite marked this pull request as ready for review March 26, 2026 15:34
@cmacknz
Copy link
Copy Markdown
Member

cmacknz commented Mar 26, 2026

Structure looks good to me. I'll approve once you get approval from someone on your team that they want this to merge.

Alternatively, for a bit more work, you can take the structural parts of this to main with a stub for the verifier receiver and I'll approve that. Then this PR will request codeowner approval from the right people and you won't need someone from agent control plane to approve everytime you push.

@cmacknz
Copy link
Copy Markdown
Member

cmacknz commented Mar 26, 2026

Actually you'll probably need our approval because of go.mod changes, so don't bother with that. Just ping me/control plane once you have approval from your own team that this is good to merge and we'll approve.

Comment thread internal/edot/receivers/verifierreceiver/config.go
@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Mar 27, 2026

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b evgb-ImpVerifier upstream/evgb-ImpVerifier
git merge upstream/main
git push upstream evgb-ImpVerifier

@jeniawhite jeniawhite requested review from a team as code owners April 3, 2026 02:47
@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Apr 3, 2026

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b evgb-ImpVerifier upstream/evgb-ImpVerifier
git merge upstream/main
git push upstream evgb-ImpVerifier

olegsu
olegsu previously approved these changes Apr 3, 2026
Copy link
Copy Markdown
Contributor

@olegsu olegsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeniawhite jeniawhite dismissed olegsu’s stale review April 3, 2026 15:46

The merge-base changed after approval.

olegsu
olegsu previously approved these changes Apr 3, 2026
@jeniawhite jeniawhite dismissed olegsu’s stale review April 3, 2026 15:51

The merge-base changed after approval.

@jeniawhite jeniawhite enabled auto-merge (squash) April 4, 2026 04:53
@elasticmachine
Copy link
Copy Markdown
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

History

cc @jeniawhite

@jeniawhite jeniawhite merged commit 174b451 into elastic:main Apr 6, 2026
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants