Skip to content

[hybrid agent] add state storage extension#12993

Merged
VihasMakwana merged 12 commits into
elastic:mainfrom
VihasMakwana:state-store-extension
Mar 16, 2026
Merged

[hybrid agent] add state storage extension#12993
VihasMakwana merged 12 commits into
elastic:mainfrom
VihasMakwana:state-store-extension

Conversation

@VihasMakwana
Copy link
Copy Markdown
Contributor

@VihasMakwana VihasMakwana commented Mar 2, 2026

What does this PR do?

This PR adds the elasticsearch_storage extension to EDOT.

Why is it important?

This is important because, unlike the process runtime, the otel runtime does not initialize the ES state store , which causes the pipeline to block in waitReady() and results in no events being emitted.

Checklist

  • I have read and understood the pull request guidelines of this project.
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

Disruptive User Impact

Testing

I had a sync with @nkvoll and he tested my changes out on the agentless-serverless buildkite pipeline: https://buildkite.com/elastic/agentless-serverless-release/builds/48/canvas.

Previously:

  • The build wasn't succeeding and was stuck in the first phase.

After my changes:

  • Build succeeds
  • Test cases are passing.
  • Data is verified.

Related issues

@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Mar 2, 2026

This pull request does not have a backport label. Could you fix it @VihasMakwana? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-./d./d is the label that automatically backports to the 8./d branch. /d is the digit
  • backport-active-all is the label that automatically backports to all active branches.
  • backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
  • backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.

Comment thread internal/pkg/otel/extension/elasticstorage/factory.go Outdated
Comment thread internal/pkg/otel/translate/otelconfig.go Outdated
@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Mar 6, 2026

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b state-store-extension upstream/state-store-extension
git merge upstream/main
git push upstream state-store-extension

@VihasMakwana
Copy link
Copy Markdown
Contributor Author

Blocked on #13106

@VihasMakwana VihasMakwana changed the title [PoC] add state storage extension [hybrid agent] add state storage extension Mar 12, 2026
@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Mar 12, 2026

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b state-store-extension upstream/state-store-extension
git merge upstream/main
git push upstream state-store-extension

@VihasMakwana VihasMakwana force-pushed the state-store-extension branch from dfb69d0 to 0ef4e4c Compare March 13, 2026 09:12
@VihasMakwana VihasMakwana marked this pull request as ready for review March 13, 2026 14:05
@VihasMakwana VihasMakwana requested a review from a team as a code owner March 13, 2026 14:05
@VihasMakwana VihasMakwana requested a review from cmacknz March 13, 2026 14:05
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@VihasMakwana VihasMakwana force-pushed the state-store-extension branch from 9864ad6 to ac1f1b2 Compare March 13, 2026 14:08
@pierrehilbert pierrehilbert added the Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team label Mar 13, 2026
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

@elasticmachine
Copy link
Copy Markdown
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

History

cc @VihasMakwana

Copy link
Copy Markdown
Member

@swiatekm swiatekm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I don't like the way we check for the feature, and I'd prefer if we made it more explicit in the future, but I'm not going to block the PR over that.

@VihasMakwana
Copy link
Copy Markdown
Contributor Author

I'll make this explicit in a follow-up. For now, I'll merge this to unblock the agentless team.

@VihasMakwana VihasMakwana merged commit 7bafad9 into elastic:main Mar 16, 2026
32 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants