[8.19] (backport #11998) (bugfix) log level does not change when standalone agent is reloaded or when otel runtime is used#12124
Closed
mergify[bot] wants to merge 1 commit into8.19from
Closed
Conversation
…or when otel runtime is used (#11998) * Fix log level does not change when standalone agent is reloaded (cherry picked from commit 85b7e99) # Conflicts: # internal/pkg/agent/application/application.go # internal/pkg/agent/application/coordinator/coordinator.go # internal/pkg/agent/application/coordinator/coordinator_test.go # internal/pkg/agent/application/coordinator/coordinator_unit_test.go # internal/pkg/otel/manager/manager.go # internal/pkg/otel/manager/manager_test.go
Contributor
Author
|
Cherry-pick of 85b7e99 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
8 tasks
Contributor
|
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
Contributor
Member
|
Let's not backport this to active minors, it's a reasonably complex change and we don't want to release it before we've had a chance to see if any problems come up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When
agent.logging.levelconfig is changed during runtime in standalone elastic-agent, the new log level was not respected. (Note: This works in managed mode. This is the code path followed by managed mode for ref https://github.com/khushijain21/elastic-agent/blob/loglevel/internal/pkg/agent/application/actions/handlers/handler_action_settings.go#L54-L94 )This PR fixes this bug and ensures this works both for process and OTel runtime.
Note: If both
agent.logging.levelandservice::telemetry::logs::levelare set - then the agent log level is applied to process runtime andtelemetry::logsis applied to OTel runtime. If not, all components useagent.logging.levelWhy is it important?
This is important so that we don't have to restart elastic-agent to update its logging level
Checklist
./changelog/fragmentsusing the changelog toolDisruptive User Impact
None
How to test this PR locally
Start standalone elastic-agent with monitoring enabled and change the logging level without restarting. Observe the debug logs.
I tested this PR manually for both process and otel mode. And by switching from INFO-DEBUG-INFO.
Related issues
elastic-otel-collectorsub-process #11959This is an automatic backport of pull request #11998 done by [Mergify](https://mergify.com).