Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.4](backport #1130) Remove the fleet reporter #1138

Merged
merged 2 commits into from
Sep 9, 2022

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Sep 9, 2022

This is an automatic backport of pull request #1130 done by Mergify.
Cherry-pick of 6e2e06c has failed:

On branch mergify/bp/8.4/pr-1130
Your branch is up to date with 'origin/8.4'.

You are currently cherry-picking commit 6e2e06c06.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   CHANGELOG.next.asciidoc
	modified:   internal/pkg/agent/application/gateway/fleet/fleet_gateway.go
	modified:   internal/pkg/agent/application/gateway/fleet/fleet_gateway_test.go
	modified:   internal/pkg/agent/application/managed_mode.go
	modified:   internal/pkg/agent/configuration/fleet.go
	modified:   internal/pkg/fleetapi/checkin_cmd.go
	deleted:    internal/pkg/reporter/fleet/config/config.go
	deleted:    internal/pkg/reporter/fleet/reporter_test.go

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	deleted by them: internal/pkg/reporter/fleet/reporter.go

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

* Remove the fleet reporter

Remove the fleet-reporter so that checkins no longer deliver the event
list.

* add CHANGELOG fix tests

(cherry picked from commit 6e2e06c)

# Conflicts:
#	internal/pkg/reporter/fleet/reporter.go
@mergify mergify bot requested a review from a team as a code owner September 9, 2022 13:43
@mergify mergify bot requested review from AndersonQ and aleksmaus and removed request for a team September 9, 2022 13:43
@mergify mergify bot added backport conflicts There is a conflict in the backported pull request labels Sep 9, 2022
@elasticmachine
Copy link
Contributor

elasticmachine commented Sep 9, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-09-09T15:50:03.429+0000

  • Duration: 15 min 15 sec

Test stats 🧪

Test Results
Failed 0
Passed 6109
Skipped 23
Total 6132

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages.

  • run integration tests : Run the Elastic Agent Integration tests.

  • run end-to-end tests : Generate the packages and run the E2E Tests.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@blakerouse
Copy link
Contributor

@Mergifyio refresh

@mergify
Copy link
Contributor Author

mergify bot commented Sep 9, 2022

refresh

✅ Pull request refreshed

@elasticmachine
Copy link
Contributor

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 97.222% (70/72) 👎 -0.038
Files 67.713% (151/223) 👎 -0.144
Classes 68.172% (302/443) 👍 0.01
Methods 51.782% (828/1599) 👎 -0.049
Lines 38.164% (9025/23648) 👎 -0.114
Conditionals 100.0% (0/0) 💚

@blakerouse blakerouse merged commit f6d3542 into 8.4 Sep 9, 2022
@blakerouse blakerouse deleted the mergify/bp/8.4/pr-1130 branch September 9, 2022 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport conflicts There is a conflict in the backported pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants