Improve observability for TestBeatsReceiverLogs#10030
Closed
swiatekm wants to merge 2 commits into
Closed
Conversation
swiatekm
added
flaky-test
swiatekm
force-pushed
the
test/unskip-testbeatsreceiver-logs
branch
from
0951003 to
f88ebb9
Compare
|
Contributor
💚 Build Succeeded
History
cc @swiatekm |
swiatekm
added
the
Team:Elastic-Agent-Control-Plane
Contributor
|
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
cmacknz
approved these changes
Sep 19, 2025
Member
cmacknz
left a comment
cmacknz
left a comment
There was a problem hiding this comment.
The test could probably be rewritten to make a config change to beats receivers in the same agent to avoid having to bypass the fixture install step, but this LGTM as a way to debug the test as is.
pchila
reviewed
Sep 22, 2025
Member
Author
|
Closing in favor of #10153. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Improves the observability and resource cleanup in the TestBeatsReceiverLogs integration test. This test is somewhat unusual in that it wants to run agent twice with different configurations, verifying that the emitted logs are the same. Our integration test fixtures don't support that very well, so we instead prepare two separate fixtures for each execution. This, however, prevented us from calling
fixture.Install, which does a lot of nice things, including cleanup and collection of diagnostics if the test fails. This change ensures that the same cleanup is applied to TestBeatsReceiverLogs.Why is it important?
This test can be flaky sometimes, and it's difficult to understand the reason without diagnostics.
Checklist
[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files[ ] I have added tests that prove my fix is effective or that my feature works[ ] I have added an entry in./changelog/fragmentsusing the changelog tool[ ] I have added an integration test or an E2E testRelated issues