Merged
Conversation
This adds memory pressure metrics to the cgroup v2 memory subsystem,
complementing the existing CPU and IO pressure metrics.
New metrics exposed:
- system.process.cgroup.memory.pressure.some.{10,60,300}.pct
- system.process.cgroup.memory.pressure.some.total
- system.process.cgroup.memory.pressure.full.{10,60,300}.pct
- system.process.cgroup.memory.pressure.full.total
The implementation:
- Adds Pressure field to MemorySubsystem struct
- Reads from memory.pressure file using existing GetPressure helper
- Gracefully handles systems without PSI support
PSI can be disabled for linux in a number of ways:
1. **Compile-time**: Controlled by `CONFIG_PSI` in `init/Kconfig`:
2. **Boot-time disabled by default**: With `CONFIG_PSI_DEFAULT_DISABLED=y`, PSI is off unless `psi=1` is passed.
3. **Boot parameter**: Can be disabled with `cgroup_disable=pressure`:
orestisfl
requested review from
AndersonQ and
belimawr
and removed request for
a team
orestisfl
added
enhancement
This was referenced Dec 11, 2025
orestisfl
added a commit
to elastic/beats
that referenced
this pull request
Dec 16, 2025
## Proposed commit message
Add memory pressure PSI metrics to the system.process.cgroup.memory
metricset, complementing the existing CPU and IO pressure metrics.
New fields added under system.process.cgroup.memory.pressure:
- pressure.some.{10,60,300}.pct - Share of time with some tasks stalled
- pressure.some.total - Total some pressure time
- pressure.full.{10,60,300}.pct - Share of time with all tasks stalled
- pressure.full.total - Total full pressure time
Closes #47604
## How to test this PR locally
### 1. Build and Run Metricbeat
```bash
cd metricbeat
go build .
```
### 2. Create Test Configuration
```yaml
metricbeat.modules:
- module: system
period: 5s
metricsets:
- process
processes: ['.*']
process.cgroups.enabled: true
output.console:
pretty: true
```
### 3. Run Metricbeat
```bash
./metricbeat -e -c /tmp/metricbeat-psi-test.yml
```
### 4. Verify Memory Pressure Fields
Look for `system.process.cgroup.memory.pressure` in the output:
```json
"memory": {
"pressure": {
"some": {
"10": { "pct": 0 },
"60": { "pct": 0 },
"300": { "pct": 0 },
"total": 0
},
"full": {
"10": { "pct": 0 },
"60": { "pct": 0 },
"300": { "pct": 0 },
"total": 0
}
}
}
```
### 5. Compare Before/After (Optional)
[compare-psi-metrics.sh](https://github.com/user-attachments/files/24191696/compare-psi-metrics.sh)
Use the comparison script to compare output from main vs this PR:
```
compare-psi-metrics.sh
Usage: ./compare-psi-metrics.sh <main-output.ndjson> <pr-output.ndjson>
```
## Related issues
- Requires elastic/elastic-agent-system-metrics#274
- Closes #47604
orestisfl
added a commit
that referenced
this pull request
Jan 16, 2026
## What does this PR do? Fixes a bug in the cgroup v2 CPU subsystem where the `Get` method was returning early when the `cpu.pressure` file doesn't exist. The change replaces `return nil` with `err = nil`, allowing the function to continue execution and fetch the remaining CPU stats (usage, system time, etc.) even when pressure stats are unavailable. Also adds a new test `TestGetCPUEmpty` that verifies the CPU subsystem correctly handles empty directories without errors. ## Why is it important? On systems where `cpu.pressure` is not available, the previous code would silently return without populating any CPU statistics. This meant that valid CPU metrics like usage and system time were being lost even though they were available in other files in the cgroup path. PSI can be disabled for linux in a number of ways: 1. **Compile-time**: Controlled by `CONFIG_PSI` in `init/Kconfig`: 2. **Boot-time disabled by default**: With `CONFIG_PSI_DEFAULT_DISABLED=y`, PSI is off unless `psi=1` is passed. 3. **Boot parameter**: Can be disabled with `cgroup_disable=pressure`: ## Related issues - Relates #274
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This adds memory pressure metrics to the cgroup v2 memory subsystem, complementing the existing CPU and IO pressure metrics.
New metrics exposed:
The implementation:
PSI can be disabled for linux in a number of ways:
CONFIG_PSIininit/Kconfig:CONFIG_PSI_DEFAULT_DISABLED=y, PSI is off unlesspsi=1is passed.cgroup_disable=pressure:Why is it important?
Important statistic to track linux performance
Checklist
CHANGELOG.mdRelated issues