Replace global logger with local logger in monitoring/adapter#341
Merged
khushijain21 merged 2 commits intoelastic:mainfrom Aug 19, 2025
Merged
Replace global logger with local logger in monitoring/adapter#341khushijain21 merged 2 commits intoelastic:mainfrom
khushijain21 merged 2 commits intoelastic:mainfrom
Conversation
6 tasks
Collaborator
💚 Build Succeeded
History
|
belimawr
approved these changes
Aug 18, 2025
kruskall
previously requested changes
Aug 18, 2025
Member
kruskall
left a comment
There was a problem hiding this comment.
similar concerns as elastic/elastic-agent-system-metrics#259 (review)
this is a binary incompatible change, I think we should first ensure we are able to bump the library in all supported branches
Contributor
Author
|
@kruskall I already have a PR up that accommodates these changes. elastic/beats#46054 (comment) |
4 tasks
This was referenced Aug 29, 2025
6 tasks
This was referenced Sep 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR replaces global logger with local logger in
monitoring/adpater.adapaterpackage is not used in elastic-agent but only in beats hence breaking changes should less significant impactA follow up PR will accommodate this in beats
Why is it important?
Checklist
Related issues