Add Elastic-Api-Version header to kibana client#148
Merged
pchila merged 2 commits intoelastic:mainfrom Sep 11, 2023
Merged
Conversation
pchila
requested review from
belimawr and
leehinman
and removed request for
a team
pchila
force-pushed
the
add-kibana-api-version
branch
from
c098a12 to
be1611e
Compare
leehinman
reviewed
Sep 8, 2023
Collaborator
💚 Build Succeeded
Historycc @pchila |
fearful-symmetry
approved these changes
Sep 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds the
Elastic-Api-Versionheader to all request to kibana Api as it's mandatory since merge of elastic/kibana#163570This is the first step of a 2-step fox for issue elastic/elastic-agent#3362: after this PR is merged we need to bump the version and use the newer version in elastic-agent.
Why is it important?
Checklist
[ ] My code follows the style guidelines of this project[ ] I have commented my code, particularly in hard-to-understand areas[ ] I have added tests that prove my fix is effective or that my feature works[ ] I have added an entry inCHANGELOG.mdAuthor's Checklist
Related issues