Conversation
|
Thanks @lcawl 🙂 |
|
@benskelker Yes of course. Should this only be merged after 7.9 is out? |
Yep. Thanks |
webmat
left a comment
There was a problem hiding this comment.
Hey @lcawl I just looked into the backports (#911 👀 ) and noticed you found and adjusted some missing shortcuts at the end of docs/using-getting-started.asciidoc 👍
Would you mind adding them in this PR for master as well?
On 7.9 release day, do you prefer to merge these PRs, or would you rather we do it? Either is fine for us 🙂
Just adding a note that if @lcawl would prefer to merge, we'll make sure the branch permissions are in place beforehand for release day. |
After I am authorized to merge this PR, will I be able to merge it despite the fact that the elasticsearch-ci/docs check is in a failed state? If not, we're in a chicken-and-egg state with elastic/docs#1932 (which changes "current" to 7.9, but is currently blocked from merging by these broken links). If we can't merge this PR until the checks are green, I think we need to temporarily set these broken links to the 7.9 docs explicitly, then revert them to "current" after 7.9 is current. |
webmat
left a comment
There was a problem hiding this comment.
Thanks for the additional adjustment on the getting started.
Me or Eric can merge despite the CI failure, so we will do it at the time you need. That will be simplest.
@lcawl please let us both know when you need us to merge this (and the other PRs) and we'll do it then.
|
7 AM Pacific on release day would be great, thanks! |
- Normalized capitalization - Using the name "Elastic Security" everywhere - Using the name "Logs Monitoring" to match the wording in the /logs/ docs
|
@ebeahan I've put in a checklist in this PR's body, with links to the PRs targeting all of the branches we'll need to deploy on release day. Some of them have been authored by Lisa and amended by me, some are 100% my own. Could you take a quick look at all of the PRs and approve them please? |
Related to elastic/docs#1932
This PR addresses the following links that will be broken when "current" shifts to the 7.9 documentation branch:
This needs to be applied to the following branches on release day: