Define fields to allow representing multiple users in an event.#869
Closed
webmat wants to merge 3 commits intoelastic:masterfrom
Closed
Define fields to allow representing multiple users in an event.#869webmat wants to merge 3 commits intoelastic:masterfrom
webmat wants to merge 3 commits intoelastic:masterfrom
Conversation
Contributor
Author
|
Ping all of the fine folks who chimed in on #809: @leehinman @neu5ron @janniten @willemdh @rw-access :-) |
5 tasks
rw-access
approved these changes
Jun 11, 2020
Contributor
rw-access
left a comment
There was a problem hiding this comment.
this is great. definitely will need that future issue/PR when we can add notes to explain the nesting, since it's not immediately obvious for many of these
Member
|
+1 for moving these additions through the RFC process 😃 |
|
I like the approach. I've been having issues mapping IAM audit logs recently. It also sets a good precedent for stuff like 'process.target.*' (for stuff like cross-process access and code injections). |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the proposal discussed in #809. In short, we now reuse all
userfields in 3 new places, in order to allow capturing more relevant users on a given event:user.effective.*is used to capture the effective user in cases of privilege escalation.user.target.*is used to capture a distinct user that is affected by an action, like IAM: Alice creates/suspends/deletes Bob.user.changes.*is used to capture the changes to an existing user. It's worth pointing out that only the attributes that change for the user are expected to be populated here.For now this PR simply adds the fields. We don't yet have a good way to have either contextual definitions around field reuse, nor a place to document this via free form text, in the user page. This will come as a later addition.
I'm opening this PR in a straighforward manner, by directly introducing these fields. However I'm thinking this major addition is probably a good candidate to move through the RFC process.
What do you think @epixa @ebeahan @tsg?
Closes #809