Remove the legacy Elasticsearch template#629
Merged
webmat merged 5 commits intoelastic:masterfrom Nov 26, 2019
Merged
Conversation
Contributor
|
You should mention this in the changelog. |
Contributor
Author
|
@ruflin Do you think I should be more verbose on this changelog? The "good" ES templates have been available for a long time in I'll definitely have a clear mention of the correct files to use in the release notes, however. |
Contributor
Author
|
Moved changelog entry to tooling section
ruflin
approved these changes
Nov 26, 2019
Contributor
ruflin
left a comment
ruflin
left a comment
There was a problem hiding this comment.
LGTM but +1 on being more verbose. At the moment it seems like the template does not exist anymore.
webmat
commented
Nov 26, 2019
| * Removed the file `schema.json` and the code generating it. #627 | ||
| * Removed the legacy Elasticsearch template. #629 | ||
| * Note: The *good* Elasticsearch templates are available in directory | ||
| `generated/elasticsearch`, this PR only removes an obsolete file. |
Contributor
Author
There was a problem hiding this comment.
@ruflin What do you think of this clarification?
ruflin
approved these changes
Nov 26, 2019
webmat
pushed a commit
to webmat/ecs
that referenced
this pull request
Nov 26, 2019
webmat
pushed a commit
that referenced
this pull request
Nov 26, 2019
dcode
pushed a commit
to dcode/ecs
that referenced
this pull request
Apr 15, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More complete Elasticsearch 6 and 7 templates are available in generated/elasticsearch.