Skip to content

Remove schema.json and the code that generates it #627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
webmat merged 5 commits into from
Nov 26, 2019
+3 −3,762
Merged

Remove schema.json and the code that generates it #627

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9ef8c2f
Remove schema.json and the code that generates it
Nov 22, 2019
8b96d69
Realized this was the only thing still in use in the script
Nov 22, 2019
cb71833
Changelog
Nov 25, 2019
4da59f0
Merge branch 'master' into remove-json
Nov 25, 2019
459aa1a
Merge branch 'master' into remove-json
Nov 26, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.next.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ Thanks, you're awesome :-) -->
#### Breaking changes

* Changed the order and column names in the csv. #621
* Removed the file `schema.json` and the code generating it. #627

#### Bugfixes

Expand Down
10 changes: 2 additions & 8 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,7 @@ check-license-headers:
# Clean deletes all temporary and generated content.
.PHONY: clean
clean:
rm -rf schema.json build
rm -rf generated/legacy/template.json
rm -rf build generated/legacy/template.json
# Clean all markdown files for use-cases
find ./use-cases -type f -name '*.md' -not -name 'README.md' -print0 | xargs -0 rm --

Expand All @@ -56,7 +55,7 @@ fmt: ve

# Alias to generate everything.
.PHONY: generate
generate: template legacy_use_cases codegen generator schema.json
generate: template legacy_use_cases codegen generator

# Run the new generator
.PHONY: generator
Expand Down Expand Up @@ -94,11 +93,6 @@ misspell:
.PHONY: reload_docs
reload_docs: generator docs

# Generate schema.json.
.PHONY: schema.json
schema.json: ve
$(PYTHON) scripts/schemas.py

# Download and setup tooling dependencies.
.PHONY: setup
setup: ve
Expand Down
Loading