Skip to content

Define field formats that were defined in Beats but not yet in ECS.#385

Merged
webmat merged 3 commits intoelastic:masterfrom
webmat:fix-beats-field-formats
Mar 15, 2019
Merged

Define field formats that were defined in Beats but not yet in ECS.#385
webmat merged 3 commits intoelastic:masterfrom
webmat:fix-beats-field-formats

Conversation

@webmat
Copy link
Copy Markdown
Contributor

@webmat webmat commented Mar 14, 2019

The 1.0.0 field definitions generated by ECS (elastic/beats#11150)
removed a few field formats that had previously been defined on the Beats side,
but were not yet part of ECS.

This adds all of the missing these fields formats to ECS, and generates a Beats
field definition file that includes them all.

@webmat webmat self-assigned this Mar 14, 2019
@webmat webmat force-pushed the fix-beats-field-formats branch from 624fb8a to 0acaf2e Compare March 14, 2019 01:14
@webmat
Copy link
Copy Markdown
Contributor Author

webmat commented Mar 14, 2019

@ruflin I don't think we should backport this to the 1.0 branch, as it wasn't part of ECS at the time we cut the 1.0.0 release. So this would officially be part of ECS as of 1.1.

I will however generate the file for Beats, in order to fix this issue for Beats 7.0.

cc @simitt

@webmat webmat requested a review from ruflin March 14, 2019 01:46
Copy link
Copy Markdown
Contributor

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@webmat webmat merged commit 7d740e3 into elastic:master Mar 15, 2019
webmat referenced this pull request in elastic/beats Mar 22, 2019
Moved the definition of `agent.hostname` to fields.common.yml
webmat pushed a commit to webmat/ecs that referenced this pull request May 24, 2019
Initial PR elastic#385 was tweaked by elastic#425. But only elastic#425 was backported to 1.0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants