State that source and destination are also a pair.#244
Merged
webmat merged 1 commit intoelastic:masterfrom Dec 7, 2018
Merged
Conversation
Just like client and server (elastic#236).
ruflin
approved these changes
Dec 7, 2018
Contributor
ruflin
left a comment
ruflin
left a comment
There was a problem hiding this comment.
I like the current phrasing and not make it more forceful. Must implies we know all the use cases which we don't.
MikePaquette
approved these changes
Dec 7, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just like client and server (#236).
I actually think the phrasing for these pairs should be more forceful. I would replace "usually populated in conjunction" with "must be populated in conjunction".
We'll already have to manage two pairs of endpoint names instead of one. A lot of content will be affected by this. The last thing I would want is to actually have to deal with even more of them: source-server, client-destination, server-destination ;-)