Skip to content

add one word to threat.yml#1505

Merged
djptek merged 3 commits intoelastic:masterfrom
djptek:threat_fields_omission
Jul 8, 2021
Merged

add one word to threat.yml#1505
djptek merged 3 commits intoelastic:masterfrom
djptek:threat_fields_omission

Conversation

@djptek
Copy link
Copy Markdown
Contributor

@djptek djptek commented Jul 8, 2021

This is a one word addition, improves readability in docs.

@djptek djptek requested a review from a team July 8, 2021 16:27
Comment thread CHANGELOG.next.md Outdated

* Swap `Location` and `Field Set` columns in `Field Reuse` table for better readability. #1472, #1476
* Use a bullet points to list field reuses. #1473
* Improve wording in `Threat` schema
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to add in the PR number!

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops! Added, Thanks @kgeller

Copy link
Copy Markdown
Member

@kgeller kgeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after the changelog addition

@djptek djptek merged commit f896135 into elastic:master Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants