Skip to content

Stage 2 changes for RFC 0008 - threat indicator fields#1471

Merged
ebeahan merged 8 commits intoelastic:masterfrom
ebeahan:rfc/0008/changes-for-stage-2
Jun 29, 2021
Merged

Stage 2 changes for RFC 0008 - threat indicator fields#1471
ebeahan merged 8 commits intoelastic:masterfrom
ebeahan:rfc/0008/changes-for-stage-2

Conversation

@ebeahan
Copy link
Copy Markdown
Member

@ebeahan ebeahan commented Jun 23, 2021

Apply stage 2 beta changes proposed in the threat indicator fields RFC 0008: #1293

Docs preview of these changes

@ebeahan ebeahan self-assigned this Jun 23, 2021
@ebeahan ebeahan added the 1.11.0 label Jun 23, 2021
@ebeahan ebeahan marked this pull request as ready for review June 24, 2021 18:02
@ebeahan ebeahan requested review from a team, peasead and rylnd June 24, 2021 18:03
Copy link
Copy Markdown
Contributor

@djptek djptek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you confirm whether the underscores and extra "\n" characters are intentional? Otherwise looks OK though feedback from a domain SME would also be helpful

Copy link
Copy Markdown
Contributor

@peasead peasead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@djptek djptek self-requested a review June 29, 2021 13:20
Copy link
Copy Markdown
Contributor

@djptek djptek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ebeahan ebeahan merged commit 742b8f3 into elastic:master Jun 29, 2021
@ebeahan ebeahan deleted the rfc/0008/changes-for-stage-2 branch June 29, 2021 15:42
ebeahan added a commit to ebeahan/ecs that referenced this pull request Jun 29, 2021
* remove experimental threat definitions

* add threat intel RFC beta fields

* add artifacts

* s/expected/recommended

* add changelog

* spaces anomaly

* artifacts
# Conflicts:
#	experimental/generated/csv/fields.csv
#	generated/csv/fields.csv
ebeahan added a commit that referenced this pull request Jun 29, 2021
* remove experimental threat definitions

* add threat intel RFC beta fields

* add artifacts

* s/expected/recommended

* add changelog

* spaces anomaly

* artifacts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants