Skip to content

[RFC] 0008: Correct expected indicator.type value for X509 Certificates#1468

Closed
adriansr wants to merge 1 commit intoelastic:masterfrom
adriansr:correct_threat_indicator_type_expected_values
Closed

[RFC] 0008: Correct expected indicator.type value for X509 Certificates#1468
adriansr wants to merge 1 commit intoelastic:masterfrom
adriansr:correct_threat_indicator_type_expected_values

Conversation

@adriansr
Copy link
Copy Markdown
Contributor

This is a minor change to a field's description in RFC 0008 (Threat Intel).

The documentation for the indicator.type field lists x-509-certificate as an expected value. However, the correct STIX 2.0 Cyber Observable type name for X509 Certificates is x509-certificate, according to the STIX 2.0 docs.

The documentation for the `indicator.type` field lists
`x-509-certificate` as an expected value. However, the correct STIX 2.0
Cyber Observable type name for X509 Certificates is `x509-certificate`.
@adriansr adriansr requested a review from shimonmodi June 23, 2021 09:04
@ebeahan ebeahan requested review from peasead and rylnd June 23, 2021 16:21
@ebeahan
Copy link
Copy Markdown
Member

ebeahan commented Jun 23, 2021

Great catch, @adriansr!

Would you also update it here in the experimental schema definitions?

I'm also adding @peasead @rylnd as reviewers.

@ebeahan
Copy link
Copy Markdown
Member

ebeahan commented Jun 23, 2021

Actually, let's handle this differently since we have an active PR for this RFC.

I cherry-picked your change @adriansr and incorporate it into #1293: 31616fa

@ebeahan ebeahan closed this Jun 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants