Skip to content

Stage 3 Orchestrator RFC#1343

Merged
ebeahan merged 4 commits intoelastic:masterfrom
ferozsalam:master
May 14, 2021
Merged

Stage 3 Orchestrator RFC#1343
ebeahan merged 4 commits intoelastic:masterfrom
ferozsalam:master

Conversation

@ferozsalam
Copy link
Copy Markdown
Contributor

@ferozsalam ferozsalam commented Apr 5, 2021 •
edited by ebeahan
Loading

RFC document preview

  • Update RFC to Stage 3
  • Document resolution to identified concern
  • Remove RFC section as the stage that requires it has been deprecated

Criteria:

  • Opened pull request for this candidate revising the existing candidate
  • Included multiple real world example source documents
  • Existing or newly raised questions and concerns are addressed
  • No objections from sponsor, ECS team, or subject matter experts

@ferozsalam ferozsalam mentioned this pull request Apr 5, 2021
Closed
@ebeahan ebeahan added the RFC label Apr 5, 2021
@ebeahan
Copy link
Copy Markdown
Member

ebeahan commented Apr 22, 2021 •
edited
Loading

Thanks for the continuing work on orchestrator.*, @ferozsalam! Your efforts here are very appreciated!

Sorry for the delay in responding here. ECS has entered the feature freeze for the 1.10 release, and the orchestrator.* fields will be released as a beta fieldset as part of 1.10. 🎉

For this PR, we'll need to ensure there are no open questions or unaddressed concerns and that the field definitions are complete based on the info and experience with have with them. I'll add some criteria in the description to help us track what's outstanding.

exekias
exekias approved these changes Apr 23, 2021
View reviewed changes
Copy link
Copy Markdown

@exekias exekias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution @ferozsalam!

ebeahan
ebeahan approved these changes May 14, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@ebeahan ebeahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Thanks all for iterating and moving those forward! 🎉

I'll set the advancement date and merge. You'll see a separate PR implementing the changes in the schema shortly.

@ebeahan ebeahan merged commit 531be4c into elastic:master May 14, 2021
@ebeahan ebeahan mentioned this pull request May 14, 2021
Merged
rylnd added a commit to rylnd/ecs that referenced this pull request May 28, 2021
@rylnd
Merge branch 'master' into threat-enrichment-stage-1
caa8983 
* master:
  Stage 2 changes for RFC 0018 - extending the `threat.*` field set (elastic#1438)
  Remove deprecated `host.user.*` fields (elastic#1439)
  Explicitly include user identifiers in `related.user` field description (elastic#1420)
  Set the merge date on RFC 0018 stage 2 (elastic#1429)
  [RFC] Extend Threat Fieldset - Stage 2 Proposal (elastic#1395)
  [Tooling] Add --exclude flag to Generator to support field removal testing (elastic#1411)
  Add `host.user.*` deprecation notice in field reuse description (elastic#1422)
  Stage 2 changes for RFC 0015 - `elf` header (elastic#1410)
  Stage 3 changes for RFC 0012 - `orchestrator` field set (elastic#1417)
  Support `match_only_text` in Go code generator (elastic#1418)
  Stage 3 Orchestrator RFC (elastic#1343)
  moving into folder (elastic#1416)
  removing use-cases (elastic#1405)
  removing --oss (elastic#1404)
  Set the merge date on RFC 0015 stage 2 (elastic#1409)
  Consolidate `Breaking changes` sections in `CHANGELOG.next` (elastic#1408)
  RFC-Stage-0: Proposal to add a "ticket" schema / field definition to ECS (elastic#1383)
  [RFC] `match_only_text` type migration - Stage 0 (elastic#1396)
  Client port is wrongly documented (elastic#1402) (elastic#1406)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ebeahan ebeahan ebeahan approved these changes

@kaiyan-sheng kaiyan-sheng Awaiting requested review from kaiyan-sheng

@jsoriano jsoriano Awaiting requested review from jsoriano

@ChrsMark ChrsMark Awaiting requested review from ChrsMark

+1 more reviewer

@exekias exekias exekias approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

RFC

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ferozsalam @ebeahan @exekias