[1.5] Add [discrete] headers to Asciidoc generator#1089
Merged
ebeahan merged 1 commit intoelastic:1.5from Nov 4, 2020
Merged
Conversation
Member
Author
|
Resolves the issue raised at #1082 (comment) |
ebeahan
changed the title
webmat
approved these changes
Nov 4, 2020
Contributor
webmat
left a comment
webmat
left a comment
There was a problem hiding this comment.
LGTM
Thanks for the fix :-)
Could you try to backport it to 1.4 and 1.3? 🙏
ebeahan
added a commit
to ebeahan/ecs
that referenced
this pull request
Nov 4, 2020
ebeahan
added a commit
to ebeahan/ecs
that referenced
this pull request
Nov 4, 2020
ebeahan
added a commit
to ebeahan/ecs
that referenced
this pull request
Nov 4, 2020
ebeahan
added a commit
that referenced
this pull request
Nov 4, 2020
ebeahan
added a commit
that referenced
this pull request
Nov 4, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I made these changes locally but failed to include them in #1003.
These changes ensure any subsequent changes to the documentations will also include the
[discrete]markers in the field details documentation section.