File.elf create

[peasead]

RFC Preview

Resolves #1062

• Have you signed the contributor license agreement? Yes
• Have you followed the contributor guidelines? Yes
• For proposing substantial changes or additions to the schema, have you reviewed the RFC process? Yes
• If submitting code/script changes, have you verified all tests pass locally using make test? Yes
• If submitting schema/fields updates, have you generated new artifacts by running make and committed those changes? Yes
• Is your pull request against master? Unless there is a good reason otherwise, we prefer pull requests against master and will backport as needed. Yes
• Have you added an entry to the CHANGELOG.next.md? Yes

[peasead]

Pinging to see if there are any blockers on this.

[ebeahan]

Thanks, @peasead, for the work on the proposal here!

I see the initial elf.* additions made directly in schemas were undone. Can you rerun make to remove the generated artifacts from the PR? Once done, this should also fix the failing checks and merge conflicts.

[peasead]

Thanks, @peasead, for the work on the proposal here!

I see the initial elf.* additions made directly in schemas were undone. Can you rerun make to remove the generated artifacts from the PR? Once done, this should also fix the failing checks and merge conflicts.

Thanks @ebeahan I tried to re-run make and got the following error

build/ve/bin/python scripts/generator.py --strict --include ""
/bin/sh: build/ve/bin/python: No such file or directory
make: *** [generator] Error 127

[ebeahan]

Sorry for the late response here, @peasead! 🙈

Try running make ve first, which will set up your Python virtualenv and install dependencies for the repo. Once that finishes, try running make once more.

[peasead]

@ebeahan just checking on this to see what the next steps are.

[ebeahan]

I pushed some edits to elf.yml to ensure the schema would generate artifacts correctly.

[ebeahan]

LGTM.

@andrewstucki @devonakerr @dcode can you perform final reviews for this stage?

[devonakerr]

PR accepted without pun, notably.

[ebeahan]

Thanks, @devonakerr. Let's move forward with advancing.

I'll push some additional changes to assign the RFC number, set the date, and rename the files appropriately.

I'll also open a separate PR to add the elf.* fields, as proposed here, into the experimental schema. @peasead I'll add you as a reviewer there, and feel free to add anyone else in who should look those changes over.