Skip to content

Correct experimental usage example#1045

Merged
ebeahan merged 3 commits intoelastic:masterfrom
ebeahan:fix-experimental-readme
Oct 22, 2020
Merged

Correct experimental usage example#1045
ebeahan merged 3 commits intoelastic:masterfrom
ebeahan:fix-experimental-readme

Conversation

@ebeahan
Copy link
Copy Markdown
Member

@ebeahan ebeahan commented Oct 22, 2020

Additional, documentation was added to USAGE.md demonstrating using --include with multiple target directories.

@ebeahan ebeahan self-assigned this Oct 22, 2020
webmat
webmat previously approved these changes Oct 22, 2020
Copy link
Copy Markdown
Contributor

@webmat webmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for fixing this

Unique identifier of the widget.
```

Multiple directory targets can also be provided:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I guess I was misunderstanding how to properly pass in multiple directories. I knew the action=append thing would make it possible to pass in the same flag multiple times, but I didn't realize we could just pass in space-separated paths as well.

Co-authored-by: Mathieu Martin <webmat@gmail.com>
Copy link
Copy Markdown
Contributor

@webmat webmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ebeahan ebeahan merged commit 13a12c0 into elastic:master Oct 22, 2020
@ebeahan ebeahan deleted the fix-experimental-readme branch October 22, 2020 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants