Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backport: use GitHub actions (linux support) (#236) #244

Closed
wants to merge 3 commits into from

Conversation

v1v
Copy link
Member

@v1v v1v commented Feb 1, 2023

Backport #236

@v1v v1v requested a review from Mpdreamz February 1, 2023 11:19
@v1v v1v self-assigned this Feb 1, 2023
@v1v v1v changed the title use GitHub actions (linux support) (#236) backport: use GitHub actions (linux support) (#236) Feb 1, 2023
@Mpdreamz
Copy link
Member

Mpdreamz commented Feb 1, 2023

https://github.com/elastic/ecs-dotnet/actions/runs/4064290493/jobs/6997544409 this seems odd it should not publish prereleases like this to nuget Unless its building from a tag.

@Mpdreamz
Copy link
Member

Mpdreamz commented Feb 1, 2023

@v1v
Copy link
Member Author

v1v commented Feb 1, 2023

https://github.com/elastic/ecs-dotnet/actions/runs/4064290493/jobs/6997544409 this seems odd it should not publish prereleases like this to nuget Unless its building from a tag.

https://github.com/elastic/ecs-dotnet/actions/runs/4064290493/workflow#L5 even the build should have not been triggered

The reason seems to be

image

c9d84f2

I wonder whether the on: create is not correct, let me double check

@v1v
Copy link
Member Author

v1v commented Feb 1, 2023

https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#create

Runs your workflow when someone creates a Git reference (Git branch or tag) in the workflow's repository.

And it seems the filter is not honoured as per actions/runner#1007 (comment)

@v1v
Copy link
Member Author

v1v commented Feb 1, 2023

https://github.com/elastic/ecs-dotnet/releases/tag/1.6.0-alpha1.50 should have not been created.

What do we do?

.github/workflows/test.yml Outdated Show resolved Hide resolved
@Mpdreamz
Copy link
Member

Mpdreamz commented Feb 1, 2023

I deleted the tag/release. Since the actual publish to nuget failed there is not other cleanup needed.

We might need to generate a new key to be able to publish again.

.github/workflows/test.yml Outdated Show resolved Hide resolved
@v1v
Copy link
Member Author

v1v commented Feb 1, 2023

We might need to generate a new key to be able to publish again.

I might need to find how to do it, do you happen to remember how?

@v1v v1v closed this Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants