This repository was archived by the owner on Sep 17, 2024. It is now read-only.
fix: update flags for the enroll command#804
Merged
mdelapenya merged 2 commits intoelastic:masterfrom Feb 23, 2021
Merged
Conversation
Contributor
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
v1v
approved these changes
Feb 23, 2021
Contributor
Author
|
jenkins run the tests please |
Contributor
Author
|
I experimented some inconsistencies in the artifactory: https://artifacts-api.elastic.co/v1/search/8.0.0-SNAPSHOT/elastic-agent?x-elastic-no-kpi=true was not retrieving artifacts at the moment the CI requested the resource. Now it's available again |
mdelapenya
added a commit
to mdelapenya/e2e-testing
that referenced
this pull request
Feb 23, 2021
* fix: update enroll command flags * chore: extract flags generation to a method
mdelapenya
added a commit
to mdelapenya/e2e-testing
that referenced
this pull request
Feb 23, 2021
* fix: update enroll command flags * chore: extract flags generation to a method
mdelapenya
added a commit
to mdelapenya/e2e-testing
that referenced
this pull request
Feb 23, 2021
* fix: update enroll command flags * chore: extract flags generation to a method
mdelapenya
added a commit
to mdelapenya/e2e-testing
that referenced
this pull request
Feb 23, 2021
* fix: update enroll command flags * chore: extract flags generation to a method
mdelapenya
added a commit
that referenced
this pull request
Feb 23, 2021
mdelapenya
added a commit
that referenced
this pull request
Feb 23, 2021
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR appends the
--url=flag to the Kibana URL and the--enrollment-token=flag to the API token arguments when enrolling an agent using Fleet mode.As it's used in three different places, we are extracting the array representing the arguments to a builder method (it requires a token), so that further updates will affect only one place.
Why is it important?
The enrollment command changed in elastic/beats#24155
Checklist
make noticein the proper directory)Author's checklist
--kibana-url, while for the enroll command uses--url. Is this inconsistency on purpose?How to test this PR locally
Related issues