This repository was archived by the owner on Sep 17, 2024. It is now read-only.
[8.0](backport #1764) fix: properly copy files from compose to elastic-package#1765
Merged
mdelapenya merged 1 commit into8.0from Nov 3, 2021
Merged
[8.0](backport #1764) fix: properly copy files from compose to elastic-package#1765mdelapenya merged 1 commit into8.0from
mdelapenya merged 1 commit into8.0from
Conversation
(cherry picked from commit 293ba96)
mdelapenya
reviewed
Nov 3, 2021
|
|
||
| elasticPackageProfileFile := filepath.Join(elasticPackageProfile, "stack", "kibana.config.yml") | ||
| // The kibana config file is only valid in 8.0.0, for other maintenance branches it's kibana.config.default.yml | ||
| elasticPackageProfileFile := filepath.Join(elasticPackageProfile, "stack", "kibana.config.8x.yml") |
Contributor
There was a problem hiding this comment.
@mtojek the 8x file name is valid for the 8.0 branch of the stack?
There was a problem hiding this comment.
This isn't meant to be branch or specific stack version like 8.0.0, but in general the stack family 8x.
Contributor
There was a problem hiding this comment.
I asked because for our 7.15 and 7.16 branches, we are using here kibana.config.default.yml file, but in master and 8.0, we are going to use kibana.config.8x.yml, to follow elastic-package's behaviour
mdelapenya
added
the
backport-skip
Contributor
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. 🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #1764 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.io/