This repository was archived by the owner on Sep 17, 2024. It is now read-only.
feat: support MSSQL Server integration in tests #1304
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdelapenya
commented
Jun 29, 2021
Comment on lines
+67
to
+68
| replacedContent := strings.ReplaceAll(content, `domain\username`, "sa") | ||
| replacedContent = strings.ReplaceAll(replacedContent, "verysecurepassword", "1234_asdf") |
Contributor
Author
There was a problem hiding this comment.
Apply default credentials in metricbeat's configuration
Contributor
💔 Tests Failed
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪Test errors
Expand to view the tests failures
|
| Test | Results |
|---|---|
| Failed | 4 |
| Passed | 214 |
| Skipped | 0 |
| Total | 218 |
Genuine test errors 
💔 There are test failures but not known flaky tests, most likely a genuine test failure.
- Name:
Initializing / End-To-End Tests / ubuntu-18.04_fleet_agent_endpoint_integration / Deploying an Endpoint makes policies to appear in the Security App – Agent Endpoint Integration - Name:
Initializing / End-To-End Tests / ubuntu-18.04_fleet_agent_endpoint_integration / Changing an Agent policy is reflected in the Security App – Agent Endpoint Integration - Name:
Initializing / End-To-End Tests / ubuntu-18.04_fleet_fleet_mode_agent / Revoking the enrollment token for the centos agent – Fleet Mode Agent - Name:
Initializing / End-To-End Tests / arm64_fleet_fleet_mode_agent / Revoking the enrollment token for the centos agent – Fleet Mode Agent
cachedout
approved these changes
Jun 29, 2021
jsoriano
approved these changes
Jun 29, 2021
Member
Just a note, in principle the integration was not broken, but its tests, that were not being executed in the usual developer workflows (elastic/beats#26526). |
Contributor
Author
Good point, I meant that the docker image used in tests for the integration was broken. Thanks for clarifying |
mergify bot
pushed a commit
that referenced
this pull request
Jun 29, 2021
(cherry picked from commit 3188742)
mergify bot
pushed a commit
that referenced
this pull request
Jun 29, 2021
(cherry picked from commit 3188742)
mergify bot
pushed a commit
that referenced
this pull request
Jun 29, 2021
(cherry picked from commit 3188742)
mdelapenya
added a commit
that referenced
this pull request
Jun 29, 2021
(cherry picked from commit 3188742) Co-authored-by: Manuel de la Peña <[email protected]>
mdelapenya
added a commit
that referenced
this pull request
Jun 29, 2021
(cherry picked from commit 3188742) Co-authored-by: Manuel de la Peña <[email protected]>
mdelapenya
added a commit
that referenced
this pull request
Jun 29, 2021
(cherry picked from commit 3188742) Co-authored-by: Manuel de la Peña <[email protected]>
8 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds the recently added "x-pack's MSSQL integration for metricbeat" to the Metricbeat test suite. We need to massage the configuration files a bit, that's why we are adding a new sanitizer for the incoming config files from Beats repo, whic basically means applying MSSQL Server's default credentials: (user:
sa, password1234_asdf).Why is it important?
We found that the MSSQL Server integration was broken in Beats (see elastic/beats#26440) , and for that reason we want to add this test as part of the regression test suite.
Checklist
make unit-test), and they are passing locallymake noticein the proper directory)Author's Checklist
How to test this PR locally
To run the unit tests:
To run the E2E tests for the new integration:
TAGS="integrations && mssql" TIMEOUT_FACTOR=3 LOG_LEVEL=TRACE DEVELOPER_MODE=true make -C e2e/_suites/metricbeat functional-testRelated issues