Skip to content
This repository was archived by the owner on Sep 17, 2024. It is now read-only.

chore: update 7.x versions#1157

Merged
mdelapenya merged 1 commit intoelastic:7.xfrom
mdelapenya:fix-versions-7.x
May 11, 2021
Merged

chore: update 7.x versions#1157
mdelapenya merged 1 commit intoelastic:7.xfrom
mdelapenya:fix-versions-7.x

Conversation

@mdelapenya
Copy link
Copy Markdown
Contributor

@mdelapenya mdelapenya commented May 11, 2021

What does this PR do?

It uses 7.x as base version everywhere.

The changes in the JSON files for testing are only replacing 8.0.0 with 7.x. In a follow-up PR, we can replace the version with the string "X.Y.Z-SNAPSHOT", and use it in the unit tests, for the sake of maintenability.

Why is it important?

Although the CI is setting the version properly (see Jenkinsfile), the local development is defaulting the values to 8.0.0-SNAPSHOT.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have run the Unit tests for the CLI, and they are passing locally
  • I have run the End-2-End tests for the suite I'm working on, and they are passing locally
  • I have noticed new Go dependencies (run make notice in the proper directory)

How to test this PR locally

To run the unit tests:

make unit-tests

Related issues

Follow-ups

A PR simplifying how the version is set in tests will simplify the bump of the version in the maintenance branches. Will send it to master, applying it to all branches.

On the same hand, the very same PRs will be sent to 7.13 too: one updating the versions, one simplifying the usage.

@mdelapenya mdelapenya self-assigned this May 11, 2021
@mdelapenya mdelapenya requested a review from a team May 11, 2021 10:41
@elasticmachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #1157 opened

  • Start Time: 2021-05-11T10:41:53.481+0000

  • Duration: 20 min 59 sec

  • Commit: b03f46e

Test stats 🧪

Test Results
Failed 0
Passed 159
Skipped 0
Total 159

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 159
Skipped 0
Total 159

@mdelapenya mdelapenya marked this pull request as ready for review May 11, 2021 11:06
@mdelapenya mdelapenya merged commit 36ee85d into elastic:7.x May 11, 2021
@mdelapenya mdelapenya deleted the fix-versions-7.x branch May 11, 2021 11:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants