Skip to content
This repository was archived by the owner on Sep 17, 2024. It is now read-only.

chore: initialise stale agent only when used#1084

Merged
mdelapenya merged 1 commit intoelastic:masterfrom
mdelapenya:stale-agent-lazy-download
Apr 23, 2021
Merged

chore: initialise stale agent only when used#1084
mdelapenya merged 1 commit intoelastic:masterfrom
mdelapenya:stale-agent-lazy-download

Conversation

@mdelapenya
Copy link
Copy Markdown
Contributor

@mdelapenya mdelapenya commented Apr 23, 2021

What does this PR do?

It removes the initialisation of the stale agent in the fleet test suite, as it's already checked in the specific step for the stale agent. We delayed fetching the stale version in #1016

Why is it important?

It fails fast when the version is not present, and for the stale agent, which is only executed on nightlies, we don't want to fail fast.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have run the Unit tests for the CLI, and they are passing locally
  • I have run the End-2-End tests for the suite I'm working on, and they are passing locally
  • I have noticed new Go dependencies (run make notice in the proper directory)

Related issues

@mdelapenya mdelapenya self-assigned this Apr 23, 2021
@mdelapenya mdelapenya requested a review from a team April 23, 2021 19:25
@elasticmachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #1084 opened

  • Start Time: 2021-04-23T19:26:09.785+0000

  • Duration: 21 min 7 sec

  • Commit: 2e37fde

Test stats 🧪

Test Results
Failed 0
Passed 142
Skipped 0
Total 142

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 142
Skipped 0
Total 142

@mdelapenya mdelapenya marked this pull request as ready for review April 23, 2021 21:11
@mdelapenya
Copy link
Copy Markdown
Contributor Author

CI passing, merging to fix builds

@mdelapenya mdelapenya merged commit f5d5e95 into elastic:master Apr 23, 2021
mergify Bot pushed a commit that referenced this pull request Apr 23, 2021
mdelapenya added a commit that referenced this pull request Apr 24, 2021
(cherry picked from commit f5d5e95)

Co-authored-by: Manuel de la Peña <mdelapenya@gmail.com>
@mdelapenya mdelapenya deleted the stale-agent-lazy-download branch April 24, 2021 05:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants