Switch the Infra Monitoring Guide to asciidoctor #698
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switches the Infrastructure Monitoring Guide to Asciidoctor. There are a few spacing changes that are noops in HTML and there are a few changes that look like this: ``` - <img alt="monitoring-architecture.png" src="monitoring-architecture.png"/> + <img alt="monitoring architecture" src="monitoring-architecture.png"/> ``` They switch the alt tag on an image from the name of the image to a "more English" version of the name of the image. I'm not sure if this is really an improvement because the alt tag is still being automatically generated so it isn't going to be particularly descriptive. But I don't *think* this is a problem either.
bmorelli25
approved these changes
Mar 11, 2019
Member
bmorelli25
left a comment
bmorelli25
left a comment
There was a problem hiding this comment.
Nice! The asciidoctor build looks perfect 👍
dedemorton
approved these changes
Mar 12, 2019
Contributor
dedemorton
left a comment
dedemorton
left a comment
There was a problem hiding this comment.
LGTM! Even for a very small "book", the asciidoctor build is notably faster. Yay!
Member
Author
|
Thanks for reviewing @dedemorton and @bmorelli25! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switches the Infrastructure Monitoring Guide to Asciidoctor. There are a
few spacing changes that are noops in HTML and there are a few changes
that look like this:
They switch the alt tag on an image from the name of the image to a
"more English" version of the name of the image. I'm not sure if this is
really an improvement because the alt tag is still being automatically
generated so it isn't going to be particularly descriptive. But I don't
think this is a problem either.