Switch the community clients book to Asciidoctor #692
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switches the community clients book in the Elasticsearch repo to Asciidoctor. The generated html has some spacing differences but our tuned html_diff tool doesn't think that there are any differences that are impactful.
Closed
lcawl
approved these changes
Mar 8, 2019
Contributor
lcawl
left a comment
lcawl
left a comment
There was a problem hiding this comment.
LGTM and builds successfully
Member
Author
|
Thanks for reviewing @lcawl! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switches the community clients book in the Elasticsearch repo to
Asciidoctor. The generated html has some spacing differences but our
tuned html_diff tool doesn't think that there are any differences that
are impactful.