Asciidoctor: Support added inline macro #548
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds support for the added inline macro which would normally be specified like this: ``` words added:[version] ``` But for compatibility with Elastic's asciidoc customizations we support specifying it like this as well: ``` words added[version] ``` Note that we'll want to build on this to add support for `coming` and `deprecated` as well.
Closed
ddillinger
reviewed
Jan 17, 2019
| expect(actual).to eq(expected.strip) | ||
| end | ||
|
|
||
| it "inline version is not invoked without the ::" do |
There was a problem hiding this comment.
Given the PR description... does this match the behavior of asciidoc too?
Member
Author
There was a problem hiding this comment.
Woops! That should be without the : instead.
Member
Author
There was a problem hiding this comment.
So, in asciidoc the inline macro is invoked without the :, but in asciidoctor it isn't. We "fix" the input to add the : in the compat preprocessor. This is a "doesn't it work how I think it should" test more than anything.
ddillinger
approved these changes
Jan 18, 2019
Member
Author
|
Thanks for reviewing @ddillinger! |
bmorelli25
pushed a commit
to bmorelli25/docs
that referenced
this pull request
Feb 15, 2019
Adds support for the added inline macro which would normally be specified like this: ``` words added:[version] ``` But for compatibility with Elastic's asciidoc customizations we support specifying it like this as well: ``` words added[version] ``` Note that we'll want to build on this to add support for `coming` and `deprecated` as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for the added inline macro which would normally be
specified like this:
But for compatibility with Elastic's asciidoc customizations we support
specifying it like this as well:
Note that we'll want to build on this to add support for
cominganddeprecatedas well.