Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Air gapped docker compose #2433

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

face0b1101
Copy link

Air-gapped docs are really useful, but it would be nicer to be able to run docker-compose up -d and docker-compose down.
Also added a README with step-by-step instructions for both vanilla docker and docker-compose.

@jonny-mcc
Copy link

Gave the instructions in your README a try but found it didn't work for me. I just get the error
~/.git-references/built-docs.git must exist and contain a reference clone of the built-docs repo
when I try and run the build.sh script. This is caused by the if statement within the script. Is this really needed seeing as the next line clones the repository that it complains is missing? Unless I missing something obvious here

@gtback
Copy link
Member

gtback commented Nov 29, 2022

@jonny-mcc the current air_gapped/build.sh script (which is being leveraged for local builds in this PR) is designed to run in CI, and given the size of the built-docs repo we want to cache as much as we can on the build image rather than cloning the entire repo on every job. If that fails for any reason we'd rather it fail (to let us know) rather than spending lots of time repeatedly cloning the repo. Not saying it's a good reason, but it is the reason. 😁

You can probably set up a local reference repo of built-docs if you want to use this to build the air-gapped docs locally.

That said, you shouldn't need to build the container if you can instead just download and run the "air-gapped" container image from our (private, internal) Docker registry.

Let me know if that helps, or if you have any other questions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants