Adds shared attributes for release doc PR URLs#1872
Merged
lcawl merged 2 commits intoelastic:masterfrom Jun 18, 2020
Merged
Conversation
gtback
approved these changes
Jun 18, 2020
Member
gtback
left a comment
gtback
left a comment
There was a problem hiding this comment.
LGTM!
Minor nit: Can we swap es-issue and es-pull for consistency?
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Kibana and Elasticsearch documentation use "{pull}" and "{issue}" attributes with different values (e.g. https://raw.githubusercontent.com/elastic/kibana/master/docs/index.asciidoc and https://raw.githubusercontent.com/elastic/elasticsearch/master/docs/Versions.asciidoc), which can cause problems when the content is used in a shared context (such as the Installation and Upgrade Guide).
This PR defines repo-specific attributes in the shared attributes file to solve the problem.