Fix error reporting when book depends on docs #1292
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a book fails to build we try to list the latest commits from each of the sources of the book. When one of the sources of that book is the docs repo *and* the docs repo was cloned with `--reference` then we were failing to list the source and crashing. This fixes that by mounting the `--reference`d repo.
Member
Author
|
This should fix the error thrown by elastic/elasticsearch#47888 |
Member
Author
|
This one is yet more fun with git. Docker makes things interesting! |
olksdr
approved these changes
Oct 14, 2019
Contributor
olksdr
left a comment
olksdr
left a comment
There was a problem hiding this comment.
Changes look sane to me. But I see that building docs is failing
Co-Authored-By: Josh Mock <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a book fails to build we try to list the latest commits from each
of the sources of the book. When one of the sources of that book is the
docs repo and the docs repo was cloned with
--referencethen we werefailing to list the source and crashing. This fixes that by mounting the
--referenced repo.