Fix parameter order in MV_CONTAINS function example#5684
Merged
Conversation
As pointed out in this comment: #3315 (comment), we should invert the order of parameters for this example to respect the best practice.
florent-leborgne
requested review from
miguel-sanchez-elastic,
stratoula and
teresaalvarezsoler
Contributor
🔍 Preview links for changed docs⏳ Building and deploying preview... View progress This comment will be updated with preview links when the build is complete. |
Contributor
✅ Vale Linting ResultsNo issues found on modified lines! The Vale linter checks documentation changes against the Elastic Docs style guide. To use Vale locally or report issues, refer to Elastic style guide for Vale. |
Contributor
|
Hi @florent-leborgne , I'll wait for other to review in case my thinking was not accurate just not be more sure. |
benironside
approved these changes
Mar 30, 2026
Contributor
benironside
left a comment
benironside
left a comment
There was a problem hiding this comment.
Approving to unblock the edit. Not a technical review.
stratoula
approved these changes
Mar 31, 2026
leemthompo
approved these changes
Mar 31, 2026
teresaalvarezsoler
approved these changes
Mar 31, 2026
teresaalvarezsoler
left a comment
teresaalvarezsoler
left a comment
There was a problem hiding this comment.
Looks good to me thanks @miguel-sanchez-elastic and @florent-leborgne. Not sure how this slipped before.
Co-authored-by: Liam Thompson <leemthompo@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As pointed out in this comment: #3315 (comment), we should invert the order of parameters for this example to respect the best practice.
Should we insist on this there with an additional note or are we good with what the MV_CONTAINS reference page says?
Generative AI disclosure