-
Notifications
You must be signed in to change notification settings - Fork 197
Fix GKE autopilot reco #4490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Fix GKE autopilot reco #4490
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
493c0cd
fix gke autopilot reco
shainaraskas 71a5b41
add computeclass instructions
shainaraskas dddfb9b
fix annotation
shainaraskas 7a46b4a
Update deploy-manage/deploy/cloud-on-k8s/virtual-memory.md
shainaraskas a7328e6
Merge branch 'main' into gke-autopilot-fixes
shainaraskas d7647a1
feedback
shainaraskas 858590f
Merge branch 'gke-autopilot-fixes' of github.com:elastic/docs-content…
shainaraskas e8b3f8e
Merge branch 'main' into gke-autopilot-fixes
shainaraskas 4506375
Apply suggestions from code review
shainaraskas b296e01
Merge branch 'main' into gke-autopilot-fixes
shainaraskas 8835f07
Merge branch 'main' into gke-autopilot-fixes
shainaraskas b4d0c0f
Update deploy-manage/deploy/cloud-on-k8s/virtual-memory.md
shainaraskas 8690e6e
Merge branch 'main' into gke-autopilot-fixes
shainaraskas File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That sentence is a bit difficult to digest.... the
when unsetis not clear (what can be set that uses a hostPath? Probably the data directory of the beat or the state directory of the Elastic agent, but theunsetstatement feels weird).Not sure if this sounds better or feels easier.... @pebrc, @shainaraskas , wdyt?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will leave this alone for now as it's outside of the scope of the original issue