-
Notifications
You must be signed in to change notification settings - Fork 197
Applies-switch cleanup for upcoming syntax #4419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Applies-switch cleanup for upcoming syntax #4419
Conversation
Vale Linting ResultsSummary: 1 warning, 3 suggestions found
|
| File | Line | Rule | Message |
|---|---|---|---|
| solutions/security/get-started/_snippets/agentless-integrations-faq.md | 7 | Elastic.EndPuntuaction | Don't end headings with punctuation. |
💡 Suggestions (3)
| File | Line | Rule | Message |
|---|---|---|---|
| explore-analyze/discover/background-search.md | 39 | Elastic.WordChoice | Consider using 'deactivated, deselected, hidden, turned off, unavailable' instead of 'disabled', unless the term is in the UI. |
| solutions/security/get-started/_snippets/agentless-integrations-faq.md | 7 | Elastic.Capitalization | 'Why isn't my agentless agent appearing in Fleet?' should use sentence-style capitalization. |
| solutions/security/get-started/_snippets/agentless-integrations-faq.md | 7 | Elastic.FirstPerson | Avoid first-person pronouns such as 'my'. |
theletterf
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
shainaraskas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm 👍 thank you for taking care of these
deploy-manage/users-roles/cluster-or-deployment-auth/managed-credentials-eck.md
Outdated
Show resolved
Hide resolved
Co-authored-by: shainaraskas <58563081+shainaraskas@users.noreply.github.com>
…redentials-eck.md Co-authored-by: shainaraskas <58563081+shainaraskas@users.noreply.github.com>
benironside
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Left one minor suggestion for your consideration. Thanks for updating the image name of the Attack discovery RBAC image to our standard format 🚀
nastasha-solomon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left two questions. Thanks for making these updates!
Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com>
Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com>
Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com>
Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com>
Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com>
Summary
This PR:
This PR should only be merged after elastic/docs-builder#2322 is merged.
CI should fail until then.
Contributes to: #4361
Generative AI disclosure