Skip to content

Conversation

@florent-leborgne
Copy link
Contributor

@florent-leborgne florent-leborgne commented Dec 18, 2025

Summary

This PR:

  • adjusts applies-switch occurrences in this repo while planning for upcoming syntax changes.
  • adjusts the order of items to have them ordered from latest to oldest when relevant

This PR should only be merged after elastic/docs-builder#2322 is merged.

CI should fail until then.

Contributes to: #4361

Generative AI disclosure

  1. Did you use a generative AI (GenAI) tool to assist in creating this contribution?
  • Yes
  • No

@florent-leborgne florent-leborgne requested review from a team as code owners December 18, 2025 17:44
@github-actions
Copy link
Contributor

github-actions bot commented Dec 18, 2025

Vale Linting Results

Summary: 1 warning, 3 suggestions found

⚠️ Warnings (1)
File Line Rule Message
solutions/security/get-started/_snippets/agentless-integrations-faq.md 7 Elastic.EndPuntuaction Don't end headings with punctuation.
💡 Suggestions (3)
File Line Rule Message
explore-analyze/discover/background-search.md 39 Elastic.WordChoice Consider using 'deactivated, deselected, hidden, turned off, unavailable' instead of 'disabled', unless the term is in the UI.
solutions/security/get-started/_snippets/agentless-integrations-faq.md 7 Elastic.Capitalization 'Why isn't my agentless agent appearing in Fleet?' should use sentence-style capitalization.
solutions/security/get-started/_snippets/agentless-integrations-faq.md 7 Elastic.FirstPerson Avoid first-person pronouns such as 'my'.

Copy link
Contributor

@theletterf theletterf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@florent-leborgne florent-leborgne changed the title applies-switch cleanup for upcoming syntax [do not merge] applies-switch cleanup for upcoming syntax Dec 18, 2025
Copy link
Collaborator

@shainaraskas shainaraskas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍 thank you for taking care of these

florent-leborgne and others added 2 commits December 19, 2025 11:27
Co-authored-by: shainaraskas <58563081+shainaraskas@users.noreply.github.com>
…redentials-eck.md

Co-authored-by: shainaraskas <58563081+shainaraskas@users.noreply.github.com>
Copy link
Contributor

@benironside benironside left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Left one minor suggestion for your consideration. Thanks for updating the image name of the Attack discovery RBAC image to our standard format 🚀

Copy link
Contributor

@nastasha-solomon nastasha-solomon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left two questions. Thanks for making these updates!

florent-leborgne and others added 4 commits January 6, 2026 10:02
Co-authored-by: Benjamin Ironside Goldstein <91905639+benironside@users.noreply.github.com>
Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com>
florent-leborgne and others added 4 commits January 7, 2026 13:53
Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com>
Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com>
Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com>
@florent-leborgne florent-leborgne changed the title [do not merge] applies-switch cleanup for upcoming syntax Applies-switch cleanup for upcoming syntax Jan 8, 2026
@florent-leborgne florent-leborgne merged commit a757959 into elastic:main Jan 8, 2026
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants