Conversation
colleenmcginnis
left a comment
colleenmcginnis
left a comment
There was a problem hiding this comment.
Some specific questions below!
src/docs-assembler/navigation.yml
Outdated
|
|
||
| # This makes sense for now. I'm not sure when these files will be | ||
| # moved to https://github.com/elastic/detection-rules. | ||
| - toc: security-docs://reference/prebuilt-rules | ||
| path_prefix: reference/prebuilt-rules |
There was a problem hiding this comment.
This can be moved up to replace lines 161-162.
There was a problem hiding this comment.
https://github.com/elastic/detection-rules. yes!
Hoping to update:
elastic/detection-rules#4507
and elastic/detection-rules#4507
In the morning.
This reverts commit 417f7af.
|
FYI @Mpdreamz we will need to merge elastic/docs-content#792 to get the final structure of the global nav. |
colleenmcginnis
left a comment
colleenmcginnis
left a comment
There was a problem hiding this comment.
Ok. I think this is pretty stable now. I left a few comments below.
| logstash-docs-md: | ||
| skip: true |
There was a problem hiding this comment.
This content is still in flux.
Thanks! I tried both and continued to see errors when building locally so I haven't deleted these items yet. Let me know if I should delete them anyway or feel free to merge this whenever you're ready for it! |
| # ✅ https://github.com/elastic/docs-content/blob/main/reference/ecs/toc.yml | ||
| - toc: docs-content://reference/ecs | ||
| path_prefix: reference/ecs | ||
| path_prefix: reference/ecs/overview |
There was a problem hiding this comment.
I did this for now for ecs, cloud, and elasticsearch. We might want to move the landing page (index.md file) from docs-content to the source repos, but I think the fix would take a while to implement because we would need to update any links that point to those files because I don't think there's a way to redirect to a page in a different repo, right?
|
Ok. I have the left nav building as I expected, but when I click on some of the links in the nav I get "page can't be found" this is (mostly?) just pages coming from the elasticsearch repo. Maybe we need to update the docset.yml in that repo with the same treatment we just gave docs-content? page-cant-be-found.mov |
|
@colleenmcginnis I believe so. I will need to add validation that |
|
Does this look right? elastic/elasticsearch#125509 |
Simplified navigation logic by restructuring method signatures and refining table of contents processing. Added support for phantom definitions in navigation files, ensuring appropriate handling of unlinked TOC folders. Refactored related classes to align with the new navigation paradigm.
|
|
3 participants
Porting recent changes from https://github.com/elastic/docs-projects/pull/464.
cc @Mpdreamz