Conversation
Contributor
There was a problem hiding this comment.
PR Overview
This pull request addresses a bug in local file serving by updating the file resolution logic.
- Updated the initial file path determination to use Path.Combine(slug, "index.md") for directories.
- Introduced a fallback block that adjusts the file path using slug + ".md" if the initial lookup fails.
Reviewed Changes
| File | Description |
|---|---|
| src/docs-builder/Http/DocumentationWebHost.cs | Updated file path resolution and fallback logic for serving documentation files |
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
Mpdreamz
approved these changes
Mar 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
#666 introduced a bug where the index.md file of a directory was not found anymore.
Changes
After trying to search for a markdown file, try to find the
/index.md.