Conversation
Contributor
There was a problem hiding this comment.
PR Overview
This PR introduces mobile navigation improvements and related layout adjustments. Key changes include:
- Enabling and configuring mobile navigation behavior and toggles.
- Updating navigation styling and header layout for improved responsiveness.
- Adjusting documentation metadata for navigation.
Reviewed Changes
| File | Description |
|---|---|
| docs/_docset.yml | Added a landing-page flag to the navigation configuration. |
| docs/index.md | Added front-matter for navigation title. |
| src/Elastic.Markdown/Slices/_Layout.cshtml | Adjusted body and container element classes to support mobile navigation. |
| src/Elastic.Markdown/Slices/Layout/_TocTreeNav.cshtml | Tweaked spacing and border classes in the table of contents navigation. |
| src/Elastic.Markdown/Slices/Layout/_TableOfContents.cshtml | Updated color classes from gray to grey for consistency with the design system. |
| src/Elastic.Markdown/Slices/Layout/_SecondaryNav.cshtml | Introduced a new secondary navigation component for mobile devices. |
| src/Elastic.Markdown/Slices/Layout/_PrimaryNavDropdownItem.cshtml | Added an onclick handler to close the hamburger menu when a dropdown item is selected. |
| src/Elastic.Markdown/Slices/Layout/_PrimaryNav.cshtml | Updated layout and expanded mobile-friendly navigation interactions. |
| src/Elastic.Markdown/Slices/Layout/_PrevNextNav.cshtml | Adjusted spacing and border colors for the previous and next navigation. |
| src/Elastic.Markdown/Slices/Layout/_PagesNav.cshtml | Reworked the pages navigation layout with mobile-specific positioning and overlay tap areas. |
| src/Elastic.Markdown/Slices/Layout/_Header.cshtml | Restructured the header to include a banner, updated navigation elements, and refined the search component. |
| src/Elastic.Markdown/Slices/Layout/_Breadcrumbs.cshtml | Modified breadcrumb styling and adjusted meta position attributes for clarity. |
Copilot reviewed 20 out of 20 changed files in this pull request and generated 2 comments.
Comments suppressed due to low confidence (1)
src/Elastic.Markdown/Slices/Layout/_PagesNav.cshtml:2
- [nitpick] The use of 'z-99' in the new changes was replaced here by 'z-40' for most parts, but if 'z-99' was intentional for overlay stacking, ensure the class uses the correct arbitrary value syntax (e.g. 'z-[99]') for consistency.
<aside class="sidebar bg-white fixed lg:sticky shadow-2xl lg:shadow-none left-[100%] group-has-[#pages-nav-hamburger:checked]/body:left-0 bottom-0 lg:left-auto pl-6 lg:pl-0 top-[calc(var(--offset-height)+1px)] order-1 w-[80%] lg:w-70 xl:w-80 shrink-0 border-r-1 border-r-grey-20 z-40 lg:z-auto">
reakaleek
force-pushed
the
feature/mobile-nav
branch
from
2d8026d to
7ea5937
Compare
Mpdreamz
pushed a commit
that referenced
this pull request
Mar 4, 2025
* Add mobile navigations * Remove landing-page feature toggle
Mpdreamz
added a commit
that referenced
this pull request
Mar 4, 2025
* stage * Simplify function * ensure binary is named bootstrap * add lambda docker build * update lambda build * Add `free-disk-space` input (#614) * Add `free-disk-space` input * Use exact commit * Simply if check on Free Disk Space (#616) * Default CurrentUrlPath to empty string while we investigate further (#618) * Fix `free-disk-space` input attempt 2 (#617) * Just compare with repository name for now (#619) * Add update-reference-index action (#622) * Update links-index.json whenever a PR get's closed (#623) * Update links-index.json whenever we push a links.json (#624) * Continue-on-error temporarily for validate-inbound-links (#627) * docs-preview: Use `since_last_remote_commit: true` for changed-files action (#628) * On ci skip if /docs folder has no docset.yml silently (#630) * On ci skip if /docs folder has no docset.yml silently * skip false not in finally * Add log message * Revert "docs-preview: Use `since_last_remote_commit: true` for changed-files …" (#629) This reverts commit ed33817. * Feature: allow the docs-build action to hint to subsequent steps to skip (#631) * Set correct deployment status (#632) * Optimize preview build to avoid checkout on pull_request* events (#633) * Add `PrimaryNav` feature (#604) * Add latest header design and adjust pages navigation * Fix unintended merge changes * fix * Pass markdownparser to directive html renderer * Change feature flag from UpperCamelCase to kebab-case * Update docs/_docset.yml * Refactor feature flags --------- Co-authored-by: Martijn Laarman <Mpdreamz@gmail.com> * Revert "Add `PrimaryNav` feature (#604)" (#635) This reverts commit 8edd22a. * Add smoke test (#637) * Add smoke test * fix * Run free-disk-space action in security-docs (#639) * Add `primary-nav` feature (#636) * Add latest header design and adjust pages navigation * Fix unintended merge changes * fix * Pass markdownparser to directive html renderer * Change feature flag from UpperCamelCase to kebab-case * Update docs/_docset.yml * Refactor feature flags * Fix case where targetUrl is null or empty * Revert Commands.cs * Don't fail-fast on matrix * Handle the case where there is no root index.md file * Fix * test * ok * fix * Fix --------- Co-authored-by: Martijn Laarman <Mpdreamz@gmail.com> * Inbound link checking, fully validate if found in links-index (#643) * Add `landing-page-path` output and use it in preview workflow (#642) * Add first-page-path output and use it in preview build workflow * Refactor * Add to test * Fix smoke test * Refactor * Fix * Fix smoke test * Fix output name in usage and add output to action.yml * Refactor smoke-tests * Fix preview-build.yml (#644) * Remove unused workflow (#646) * Add validate command for single published repository (#648) Update command to be rooted to `docs-assembler inbound-links <command>` * Refactor link index command into dedicated LinkRegistry module (#649) Moved the "create-index" command from InboundLinkCommands to a new LinkRegistryCommands class for better modularity and maintainability. Updated program registration to include the new LinkRegistryCommands module and renamed the command to "update" for clarity. * Better error messages for cross_link errors (From `docs-builder` and `docs-assembler`) (#651) * Ensure inbound links validation skips docset.yml declared repositories validation * Add warning that link links to repository not in yet in the registry * Add better errors to docs-builder to (link to links.json file) * Add logging to git remote resolving (#652) * Update cross-repo links syntax info (#654) * If GITHUB_REPOSITORY is set use it verbatim (#655) * Share inbound-links commands with `docs-builder` (#657) * Fix `environment_url` in preview deployment (#658) * Adjust links and wording in primary and secondary navigation (#659) * Add mobile navigations (#662) * Add mobile navigations * Remove landing-page feature toggle * Add extension hook points to all special usecases to inject themselves into docs build process (#666) * Move detection-rules support behind an extension system * Move EnabledExtensions to Configuration * add untracked files * Add documentation for extensions * Add more extensions points to isolate the DetectionRule extension further * Isolate file scanning in DocumentationSet * Do a ful parse * Rename binary to follow kebab-case convention * Move lambda.DockerFile * Update lambda.DockerFile * Update README.md for publish-links-index-lambda with build instructions * Update src/docs-lambda-index-publisher/lambda.DockerFile Co-authored-by: Jan Calanog <jan.calanog@elastic.co> --------- Co-authored-by: Jan Calanog <jan.calanog@elastic.co> Co-authored-by: Liam Thompson <32779855+leemthompo@users.noreply.github.com>
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cursorful-video-mobile-nav-1740997107545.mp4