Skip to content

Default CurrentUrlPath to empty string while we investigate further #618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mpdreamz merged 1 commit into from
Feb 26, 2025
Merged

Default CurrentUrlPath to empty string while we investigate further #618

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/Elastic.Markdown/IO/DocumentationFile.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,4 +53,3 @@ public record SnippetFile(IFileInfo SourceFile, IDirectoryInfo RootPath)
}

public record SnippetAnchors(string[] Anchors, IReadOnlyCollection<PageTocItem> TableOfContentItems);

8 changes: 5 additions & 3 deletions src/Elastic.Markdown/Myst/ParserContext.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,9 +75,11 @@ public ParserContext(ParserState state)

CurrentUrlPath = DocumentationFileLookup(parentPath ?? MarkdownSourcePath) is MarkdownFile md
? md.Url
: SkipValidation
? string.Empty
: throw new Exception($"Unable to find documentation file for {(parentPath ?? MarkdownSourcePath).FullName}");
: string.Empty;
if (SkipValidation && string.IsNullOrEmpty(CurrentUrlPath))
{
//TODO investigate this deeper.
}

if (YamlFrontMatter?.Properties is not { Count: > 0 })
Substitutions = Configuration.Substitutions;
Expand Down