Skip to content

fix: nullable Error dereference after ES client 9.3.3 upgrade #2959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
reakaleek merged 1 commit into from
Mar 24, 2026
Merged

fix: nullable Error dereference after ES client 9.3.3 upgrade #2959

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/services/Elastic.Documentation.Search/ChangesGateway.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ public async Task<ChangesResult> GetChangesAsync(ChangesRequest request, Cancel

if (!response.IsValidResponse)
{
var reason = response.ElasticsearchServerError?.Error.Reason ?? "Unknown";
var reason = response.ElasticsearchServerError?.Error?.Reason ?? "Unknown";
throw new InvalidOperationException(
$"Elasticsearch changes query failed (HTTP {response.ApiCallDetails?.HttpStatusCode}): {reason}"
);
Expand Down Expand Up @@ -97,9 +97,9 @@ await clientAccessor.Client.SearchAsync<DocumentationDocument>(s =>
}, ctx);

private static bool IsExpiredPit(SearchResponse<DocumentationDocument> response) =>
response.ElasticsearchServerError?.Error.Type is "search_phase_execution_exception"
|| response.ElasticsearchServerError?.Error.Reason?.Contains("point in time", StringComparison.OrdinalIgnoreCase) == true
|| response.ElasticsearchServerError?.Error.Reason?.Contains("No search context found", StringComparison.OrdinalIgnoreCase) == true;
response.ElasticsearchServerError?.Error?.Type is "search_phase_execution_exception"
|| response.ElasticsearchServerError?.Error?.Reason?.Contains("point in time", StringComparison.OrdinalIgnoreCase) == true
|| response.ElasticsearchServerError?.Error?.Reason?.Contains("No search context found", StringComparison.OrdinalIgnoreCase) == true;

private static ChangesResult BuildResult(SearchResponse<DocumentationDocument> response, int pageSize)
{
Expand Down
2 changes: 1 addition & 1 deletion src/services/Elastic.Documentation.Search/SharedPointInTimeManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ private async Task<string> OpenPit(Cancel ctx)
if (!response.IsValidResponse)
{
throw new InvalidOperationException(
$"Failed to open PIT: {response.ElasticsearchServerError?.Error.Reason ?? "Unknown"}"
$"Failed to open PIT: {response.ElasticsearchServerError?.Error?.Reason ?? "Unknown"}"
);
}

Expand Down
Loading