Skip to content

Bump Elastic.Clients.Elasticsearch from 9.3.0 to 9.3.3 #2946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
reakaleek merged 2 commits into from
Mar 24, 2026
Merged

Bump Elastic.Clients.Elasticsearch from 9.3.0 to 9.3.3 #2946

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
da622b6
Bump Elastic.Clients.Elasticsearch from 9.3.0 to 9.3.3
dependabot[bot] Mar 23, 2026
0bccce6
Fix nullable reference warnings from Elastic.Clients.Elasticsearch 9.3.2
reakaleek Mar 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Directory.Packages.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@
<PackageVersion Include="Generator.Equals" Version="3.3.0" PrivateAssets="all" IncludeAssets="runtime; build; native; contentfiles; analyzers; buildtransitive" />
<PackageVersion Include="KubernetesClient" Version="18.0.5" />
<PackageVersion Include="Elastic.Aspire.Hosting.Elasticsearch" Version="9.3.0" />
<PackageVersion Include="Elastic.Clients.Elasticsearch" Version="9.3.0" />
<PackageVersion Include="Elastic.Clients.Elasticsearch" Version="9.3.3" />
<PackageVersion Include="FakeItEasy" Version="9.0.1" />
<PackageVersion Include="Elastic.Ingest.Elasticsearch" Version="0.34.5" />
<PackageVersion Include="Elastic.Mapping" Version="0.40.0" />
Expand Down
14 changes: 10 additions & 4 deletions src/services/Elastic.Documentation.Search/Common/SearchQueryBuilder.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,10 +37,16 @@ public static class SearchQueryBuilder
/// Shared document filter that excludes hidden documents and root URLs.
/// </summary>
public static Query DocumentFilter { get; } =
!(Query)new TermsQuery(
Infer.Field<DocumentationDocument>(f => f.Url.Suffix("keyword")),
new TermsQueryField(["/docs", "/docs/", "/docs/404", "/docs/404/"]))
&& !(Query)new TermQuery { Field = Infer.Field<DocumentationDocument>(f => f.Hidden), Value = true };
new BoolQuery
{
MustNot =
[
new TermsQuery(
Infer.Field<DocumentationDocument>(f => f.Url.Suffix("keyword")),
new TermsQueryField(["/docs", "/docs/", "/docs/404", "/docs/404/"])),
new TermQuery { Field = Infer.Field<DocumentationDocument>(f => f.Hidden), Value = true }
]
};

/// <summary>
/// Builds a diminish terms query to reduce scoring for common/noisy terms.
Expand Down
4 changes: 2 additions & 2 deletions src/services/Elastic.Documentation.Search/FullSearchGateway.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ private async Task<FullSearchResult> SearchWithHybridRrf(FullSearchRequest reque
if (!response.IsValidResponse)
{
logger.LogWarning("Elasticsearch response is not valid. Reason: {Reason}",
response.ElasticsearchServerError?.Error.Reason ?? "Unknown");
response.ElasticsearchServerError?.Error?.Reason ?? "Unknown");
}

return ProcessSearchResponse(response, request.Query, isSemanticQuery: true, request.IncludeHighlighting);
Expand Down Expand Up @@ -208,7 +208,7 @@ private async Task<FullSearchResult> SearchLexicalOnly(FullSearchRequest request
if (!response.IsValidResponse)
{
logger.LogWarning("Elasticsearch response is not valid. Reason: {Reason}",
response.ElasticsearchServerError?.Error.Reason ?? "Unknown");
response.ElasticsearchServerError?.Error?.Reason ?? "Unknown");
}

return ProcessSearchResponse(response, request.Query, isSemanticQuery: false, request.IncludeHighlighting);
Expand Down
2 changes: 1 addition & 1 deletion src/services/Elastic.Documentation.Search/NavigationSearchGateway.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ public async Task<NavigationSearchResult> SearchImplementation(string query, int
if (!response.IsValidResponse)
{
logger.LogWarning("Elasticsearch response is not valid. Reason: {Reason}",
response.ElasticsearchServerError?.Error.Reason ?? "Unknown");
response.ElasticsearchServerError?.Error?.Reason ?? "Unknown");
}

return ProcessSearchResponse(response, searchQuery);
Expand Down
2 changes: 1 addition & 1 deletion tests-integration/Search.IntegrationTests/SearchRelevanceTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ public async Task SearchReturnsExpectedFirstResultWithExplain(string query, stri
if (results.Count == 0)
{
var countResponse = await clientAccessor.Client.CountAsync(c => c.Indices(clientAccessor.SearchIndex), TestContext.Current.CancellationToken);
output.WriteLine($"Index document count: {(countResponse.IsValidResponse ? countResponse.Count.ToString(CultureInfo.InvariantCulture) : $"ERROR: {countResponse.ElasticsearchServerError?.Error.Reason}")}");
output.WriteLine($"Index document count: {(countResponse.IsValidResponse ? countResponse.Count.ToString(CultureInfo.InvariantCulture) : $"ERROR: {countResponse.ElasticsearchServerError?.Error?.Reason}")}");
}

results.Should().NotBeEmpty($"Search for '{query}' should return results (index: {clientAccessor.SearchIndex})");
Expand Down
Loading