Skip to content

Fix location_table access pattern #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
florianl merged 2 commits into from
Jul 2, 2025
Merged

Fix location_table access pattern #27

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4bfd7ed
fix
fandreuz Jun 16, 2025
d31ab72
fmt
fandreuz Jun 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions src/collector/otlp/service.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ impl pb_collector::profiles_service_server::ProfilesService for ProfilesService

let st = &profile.sample_type[0];
for sample in &profile.sample {
process_sample(dict, &loc_mapping, &st, sample)?;
process_sample(dict, &loc_mapping, &st, sample, &profile.location_indices)?;
}
}
}
Expand Down Expand Up @@ -280,6 +280,7 @@ fn process_sample(
loc_mapping: &Vec<Frame>,
sample_type: &ValueType,
sample: &Sample,
profile_location_indices: &Vec<i32>,
) -> Result<(), Status> {
let loc_start = sample.locations_start_index as usize;
let loc_len = sample.locations_length as usize;
Expand All @@ -288,8 +289,15 @@ fn process_sample(
// Collect frame list.
let mut frame_list = Vec::with_capacity(loc_rng.len().min(128));
for loc_index in loc_rng {
let Some(frame) = loc_mapping.get(loc_index as usize) else {
return Err(Status::invalid_argument("location index is out of bounds"));
let Some(location_table_idx) = profile_location_indices.get(loc_index as usize) else {
return Err(Status::invalid_argument(
"location_indices: index is out of bounds",
));
};
let Some(frame) = loc_mapping.get(*location_table_idx as usize) else {
return Err(Status::invalid_argument(
"location_table: index is out of bounds",
));
};
frame_list.push(*frame);
}
Expand Down
Loading