[Rule Tuning] Expanding coverage for First Occurrence of Entra ID Auth via DeviceCode Protocol#4466
Merged
terrancedejesus merged 7 commits intomainfrom Feb 20, 2025
Conversation
|
⛔️ Tests failed:
|
First Occurrence of Entra ID Auth via DeviceCode ProtocolFirst Occurrence of Entra ID Auth via DeviceCode Protocol
|
⛔️ Tests failed:
|
Aegrah
approved these changes
Feb 19, 2025
|
⛔️ Tests failed:
|
|
⛔️ Tests failed:
|
|
⛔️ Tests failed:
|
Contributor
Author
|
@Mikaayenson @eric-forte-elastic - Approval please when time permits. |
|
⛔️ Tests failed:
|
|
⛔️ Tests failed:
|
Mikaayenson
approved these changes
Feb 20, 2025
Mikaayenson
reviewed
Feb 21, 2025
Comment on lines
+20
to
+22
| note = """## Triage and analysis | ||
|
|
||
| ## Triage and Analysis |
Mikaayenson
reviewed
Feb 21, 2025
| setup = """ | ||
| This rule optionally requires Azure Sign-In logs from the Azure integration. Ensure that the Azure integration is correctly set up and that the required data is being collected. | ||
| """ | ||
| setup = "This rule optionally requires Azure Sign-In logs from the Azure integration. Ensure that the Azure integration is correctly set up and that the required data is being collected.\n" |
Contributor
There was a problem hiding this comment.
Also probably don't need the \n
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Issue link(s):
Summary - What I changed
Expands
First Occurrence of Entra ID Auth via DeviceCode Protocolquery logic to include the following below. Device code flow is reported for the original transfer method if refresh tokens are used to obtain another access token. The originalazure.signinlogs.properties.authentication_protocolcan be reported asnoneand thus miss this activity. Updated the investigation guide as well.Refs:
How To Test
Please refer to our meta notes for testing and emulation.
Checklist
bug,enhancement,schema,maintenance,Rule: New,Rule: Deprecation,Rule: Tuning,Hunt: New, orHunt: Tuningso guidelines can be generatedmeta:rapid-mergelabel if planning to merge within 24 hoursContributor checklist