-
Notifications
You must be signed in to change notification settings - Fork 516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add flag to update the docs/ATT&CK-coverage.md with markdown URL(s) #4077
Conversation
Bug - GuidelinesThese guidelines serve as a reminder set of considerations when addressing a bug in the code. Documentation and Context
Code Standards and Practices
Testing
Additional Checks
|
Please note we need to decide the deployment model for this before merging, but the code can be reviewed |
The deployment model is the workflow file to be run as part of the release process. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟢 Manual review, looks good to me! 👍
Pull Request
Issue link(s): #4007
Summary - What I changed
Add a flag
--update-coverage
to update the markdown links indocs/ATT&CK-coverage.md
Currently I have used my GIST to test this, changes to
docs/ATT&CK-coverage.md
should be reverted before merging.To Discuss / Design
Preliminary discussion with Mika
Code review to be done based on the above deploy model as well.
How To Test
docs/ATT&CK-coverage.md
which should be reverted before merging!Workflow Testing After upgrading peter-evans/create-pull-request to v7.0.3
Checklist
bug
,enhancement
,schema
,Rule: New
,Rule: Deprecation
,Rule: Tuning
,Hunt: New
, orHunt: Tuning
so guidelines can be generatedmeta:rapid-merge
label if planning to merge within 24 hoursContributor checklist