Conversation
Collaborator
Rule: Tuning - GuidelinesThese guidelines serve as a reminder set of considerations when tuning an existing rule. Documentation and Context
Rule Metadata Checks
Testing and Validation
|
Aegrah
approved these changes
Aug 28, 2024
Samirbous
approved these changes
Aug 28, 2024
terrancedejesus
approved these changes
Sep 3, 2024
Contributor
Author
|
Merging those with min_stack to unblock other 3rd party EDR work. |
protectionsmachine
pushed a commit
that referenced
this pull request
Oct 11, 2024
* [Rule Tuning] 3rd Party EDR Compatibility - 6 * min_stack for merge, bump updated_date Removed changes from: - rules/windows/defense_evasion_file_creation_mult_extension.toml - rules/windows/defense_evasion_from_unusual_directory.toml - rules/windows/defense_evasion_hide_encoded_executable_registry.toml - rules/windows/defense_evasion_iis_httplogging_disabled.toml - rules/windows/defense_evasion_masquerading_as_elastic_endpoint_process.toml - rules/windows/defense_evasion_masquerading_suspicious_werfault_childproc.toml - rules/windows/defense_evasion_masquerading_trusted_directory.toml - rules/windows/defense_evasion_microsoft_defender_tampering.toml - rules/windows/defense_evasion_ms_office_suspicious_regmod.toml (selectively cherry picked from commit fbe17eb)
protectionsmachine
pushed a commit
that referenced
this pull request
Oct 11, 2024
* [Rule Tuning] 3rd Party EDR Compatibility - 6 * min_stack for merge, bump updated_date Removed changes from: - rules/windows/defense_evasion_file_creation_mult_extension.toml - rules/windows/defense_evasion_from_unusual_directory.toml - rules/windows/defense_evasion_hide_encoded_executable_registry.toml - rules/windows/defense_evasion_iis_httplogging_disabled.toml - rules/windows/defense_evasion_masquerading_as_elastic_endpoint_process.toml - rules/windows/defense_evasion_masquerading_suspicious_werfault_childproc.toml - rules/windows/defense_evasion_masquerading_trusted_directory.toml - rules/windows/defense_evasion_microsoft_defender_tampering.toml - rules/windows/defense_evasion_ms_office_suspicious_regmod.toml (selectively cherry picked from commit fbe17eb)
protectionsmachine
pushed a commit
that referenced
this pull request
Oct 11, 2024
* [Rule Tuning] 3rd Party EDR Compatibility - 6 * min_stack for merge, bump updated_date Removed changes from: - rules/windows/defense_evasion_file_creation_mult_extension.toml - rules/windows/defense_evasion_from_unusual_directory.toml - rules/windows/defense_evasion_hide_encoded_executable_registry.toml - rules/windows/defense_evasion_iis_httplogging_disabled.toml - rules/windows/defense_evasion_masquerading_as_elastic_endpoint_process.toml - rules/windows/defense_evasion_masquerading_suspicious_werfault_childproc.toml - rules/windows/defense_evasion_masquerading_trusted_directory.toml - rules/windows/defense_evasion_microsoft_defender_tampering.toml - rules/windows/defense_evasion_ms_office_suspicious_regmod.toml (selectively cherry picked from commit fbe17eb)
protectionsmachine
pushed a commit
that referenced
this pull request
Oct 11, 2024
* [Rule Tuning] 3rd Party EDR Compatibility - 6 * min_stack for merge, bump updated_date (cherry picked from commit fbe17eb)
protectionsmachine
pushed a commit
that referenced
this pull request
Oct 11, 2024
* [Rule Tuning] 3rd Party EDR Compatibility - 6 * min_stack for merge, bump updated_date (cherry picked from commit fbe17eb)
protectionsmachine
pushed a commit
that referenced
this pull request
Oct 11, 2024
* [Rule Tuning] 3rd Party EDR Compatibility - 6 * min_stack for merge, bump updated_date (cherry picked from commit fbe17eb)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues
Summary
Adjusts to rules to introduce or improve compatibility and documentation with 3rd party data such as Sysmon, MDE, and S1.
EDR field compatibility matrix: https://docs.google.com/spreadsheets/d/1ZaRmSXIVYLO9AGXeZge3u0W938aGxbfd6Vha52Rs1_I/edit?usp=sharing
Blocker
To use SentinelOne cloud funnel data right now, we would need to min_stack the rules to 8.13, so we are going to hold off on merging these until 8.16 is released and support for 8.12 is dropped. The updated_date is set to the 8.16 public release date.